Skip to content

feat: add navigationBarTranslucent prop for Android navigation bar support #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sameed1998 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add navigationBarTranslucent prop for Android navigation bar support #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ declare module 'react-native-select-dropdown' {
* required to set true when statusbar is translucent (android only)
*/
statusBarTranslucent?: boolean;
/**
* Determines whether your modal should go under the system navigationbar.
*/
navigationBarTranslucent?: boolean;
/**
* style object for dropdown view
*/
Expand Down
3 changes: 2 additions & 1 deletion src/SelectDropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ const SelectDropdown = (
onScrollEndReached /* function */,
/////////////////////////////
statusBarTranslucent /* boolean */,
navigationBarTranslucent /* boolean */,
dropdownStyle /* style object for search input */,
dropdownOverlayColor /* string */,
showsVerticalScrollIndicator /* boolean */,
Expand Down Expand Up @@ -164,7 +165,7 @@ const SelectDropdown = (
const renderDropdown = () => {
return (
isVisible && (
<DropdownModal statusBarTranslucent={statusBarTranslucent} visible={isVisible} onRequestClose={onRequestClose}>
<DropdownModal navigationBarTranslucent={navigationBarTranslucent} statusBarTranslucent={statusBarTranslucent} visible={isVisible} onRequestClose={onRequestClose}>
<DropdownOverlay onPress={closeDropdown} backgroundColor={dropdownOverlayColor} />
<DropdownWindow layoutStyle={dropdownWindowStyle}>
<FlatList
Expand Down
4 changes: 3 additions & 1 deletion src/components/DropdownModal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import React from 'react';
import {Modal} from 'react-native';

const DropdownModal = ({visible, statusBarTranslucent, onRequestClose, children}) => {
const DropdownModal = ({visible, statusBarTranslucent, onRequestClose, children, navigationBarTranslucent}) => {
const defaults = {
statusBarTranslucent: statusBarTranslucent || false,
navigationBarTranslucent: navigationBarTranslucent || false,
};
return (
<Modal
Expand All @@ -12,6 +13,7 @@ const DropdownModal = ({visible, statusBarTranslucent, onRequestClose, children}
animationType="none"
transparent={true}
statusBarTranslucent={defaults.statusBarTranslucent}
navigationBarTranslucent={defaults.navigationBarTranslucent}
visible={visible}>
{children}
</Modal>
Expand Down