Add event handler to update postion on mouse wheel events #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I am working on a project where we use this library to implement image magnifying but with the ability to zoom in/out using the mouse wheel. For that I need updates on the item position when the mouse wheel is used, my pull request implements this and fits my requirements.
Do you see any problems with this? If not, I'd be happy to see this merged into your library & pushed to npm.
Thanks and kind regards,
Florian
Edit: I just saw that the current implementation, that I am working on, is a fork of your Side-By-Side magnifier with the possibility to use the scroll wheel (-> the SideBySideMagnifier has a scale property which is set from outside on wheel events) so you know which problem I am trying to solve with this.