Earth - Kal #44
Open
Earth - Kal #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Nov 29, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Kal, thanks for getting this in. The methods you wrote all work, but I had some feedback on time/space complexity.
Comment on lines
+3
to
5
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def factorial(n) |
Comment on lines
+11
to
+13
| # Time complexity: O(n^2), where n is the length of the string | ||
| # Space complexity: O(n^2), where n is the length of the string | ||
| def reverse(s, pointer = s.length - 1) |
Comment on lines
+19
to
21
| # Time complexity: O(n), where n is the length of the string. (More precisely, n/2) | ||
| # Space complexity: O(n), where n is the length of the string. (More precisely, n/2) | ||
| def reverse_inplace(s) |
Comment on lines
+35
to
37
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def bunny(n) |
Comment on lines
+43
to
+45
| # Time complexity: O(n), where n is the length of the string | ||
| # Space complexity: O(n), where n is the length of the string | ||
| def nested(s, parens_counter = 0, pointer = 0) |
Comment on lines
+53
to
+55
| # Time complexity: O(n), where n is the length of the string | ||
| # Space complexity: O(n), where n is the length of the string | ||
| def search(array, value, pointer = 0) |
Comment on lines
+61
to
+63
| # Time complexity: O(n), where n is the length of the string (More precisely, n/2) | ||
| # Space complexity: O(n), where n is the length of the string (More precisely, n/2) | ||
| def is_palindrome(s, length = s.length, pointer = 0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.