Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .idea/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions .idea/.rakeTasks

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/inspectionProfiles/Project_Default.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions .idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions .idea/modules.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 27 additions & 0 deletions .idea/recursion-writing.iml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/vcs.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
GEM
remote: https://rubygems.org/
specs:
ansi (1.5.0)
builder (3.2.4)
coderay (1.1.3)
method_source (1.0.0)
minitest (5.14.2)
minitest-reporters (1.4.2)
ansi
builder
minitest (>= 5.0)
ruby-progressbar
minitest-skip (0.0.3)
minitest (~> 5.0)
minitest-spec (0.0.2.1)
minitest (>= 3.0)
pry (0.13.1)
coderay (~> 1.1)
method_source (~> 1.0)
rake (13.0.1)
ruby-progressbar (1.10.1)

PLATFORMS
ruby

DEPENDENCIES
minitest
minitest-reporters
minitest-skip
minitest-spec
pry
rake

BUNDLED WITH
2.1.4
99 changes: 69 additions & 30 deletions lib/recursive-methods.rb
Original file line number Diff line number Diff line change
@@ -1,49 +1,88 @@
# Authoring recursive algorithms. Add comments including time and space complexity for each method.

# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n)
# Space complexity: O(n)
def factorial(n)
Comment on lines +3 to 5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented"
if n == 0
return 1
elsif n < 0
raise ArgumentError
else
return n * factorial(n-1)
end
end

# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n)
# Space complexity: O(n)
def reverse(s)
Comment on lines +15 to 17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 However the space & time complexity are O(n^2) because the slice you do has space/time complexity of O(n)

raise NotImplementedError, "Method not implemented"
if s.length <= 1
return s
else
return reverse(s[1..-1]) + s[0]
end
end

# Time complexity: ?
# Space complexity: ?
# # Time complexity: O(1)
# # Space complexity: O(1)
def reverse_inplace(s)
Comment on lines +25 to 27

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ How could you reverse an entire string in O(1) time?

Also you're using the exact method I told you not to use.

raise NotImplementedError, "Method not implemented"
if s.length <= 1
return s
else
return s.reverse!
end
end

# Time complexity: ?
# Space complexity: ?
#
# # Time complexity: O(n)
# # Space complexity: O(n)
def bunny(n)
raise NotImplementedError, "Method not implemented"
Comment on lines +35 to -24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if n == 0
return 0
else
return 2 + bunny(n-1)
end
end

# Time complexity: ?
# Space complexity: ?
#
# # Time complexity: O(n^2) * not sure about this one
# # Space complexity: O(n^2) * same here?
def nested(s)
Comment on lines +45 to 47

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Correct!

raise NotImplementedError, "Method not implemented"
if s == ""
return true
elsif
s[0] == "(" && s[-1] == ")"
return nested(s[1..-2])
else
return false
end
end

# Time complexity: ?
# Space complexity: ?
#
# # Time complexity: O(n)
# # Space complexity: O(n^2)
def search(array, value)
Comment on lines +58 to 60

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but once again the time complexity is O(n^2)

raise NotImplementedError, "Method not implemented"
if array.nil?
return false
elsif
array[0] == value
return true
else
return search(array[1..-1], value)
end
end

# Time complexity: ?
# Space complexity: ?
#
# # Time complexity: O(n)
# # Space complexity: O(n)
def is_palindrome(s)
Comment on lines +71 to 73

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but once again the time complexity is O(n^2)

raise NotImplementedError, "Method not implemented"
if s.length <= 1
return true
elsif s[0] != s[-1]
return false
else
return is_palindrome(s[1..-2])
end
end

# Time complexity: ?
# Space complexity: ?
#
# # Time complexity: ?
# # Space complexity: ?
def digit_match(n, m)
raise NotImplementedError, "Method not implemented"
end
#Not sure how to get started on this one.
end

6 changes: 3 additions & 3 deletions test/recursion_writing_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@
end
end

xdescribe "nested" do
describe "nested" do
it "will return true for empystring" do
# Arrange
string = ""
Expand Down Expand Up @@ -213,7 +213,7 @@
end
end

xdescribe "search" do
describe "search" do
it "will return false for empty array" do
# Arrange
item = "a"
Expand Down Expand Up @@ -263,7 +263,7 @@
end
end

xdescribe "is_palindrome" do
describe "is_palindrome" do
it "will return true for emptystring" do
# Arrange
string = ""
Expand Down