-
Notifications
You must be signed in to change notification settings - Fork 53
Water - Sophia #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Water - Sophia #43
Changes from all commits
ee09dd2
c1f668f
8dd13ee
a16907b
445118c
b115bb1
1ee2c0f
b7a60d3
01b6997
d0f3ed7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| GEM | ||
| remote: https://rubygems.org/ | ||
| specs: | ||
| ansi (1.5.0) | ||
| builder (3.2.4) | ||
| coderay (1.1.3) | ||
| method_source (1.0.0) | ||
| minitest (5.14.2) | ||
| minitest-reporters (1.4.2) | ||
| ansi | ||
| builder | ||
| minitest (>= 5.0) | ||
| ruby-progressbar | ||
| minitest-skip (0.0.3) | ||
| minitest (~> 5.0) | ||
| minitest-spec (0.0.2.1) | ||
| minitest (>= 3.0) | ||
| pry (0.13.1) | ||
| coderay (~> 1.1) | ||
| method_source (~> 1.0) | ||
| rake (13.0.1) | ||
| ruby-progressbar (1.10.1) | ||
|
|
||
| PLATFORMS | ||
| ruby | ||
|
|
||
| DEPENDENCIES | ||
| minitest | ||
| minitest-reporters | ||
| minitest-skip | ||
| minitest-spec | ||
| pry | ||
| rake | ||
|
|
||
| BUNDLED WITH | ||
| 2.1.4 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,49 +1,88 @@ | ||
| # Authoring recursive algorithms. Add comments including time and space complexity for each method. | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def factorial(n) | ||
| raise NotImplementedError, "Method not implemented" | ||
| if n == 0 | ||
| return 1 | ||
| elsif n < 0 | ||
| raise ArgumentError | ||
| else | ||
| return n * factorial(n-1) | ||
| end | ||
| end | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def reverse(s) | ||
|
Comment on lines
+15
to
17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 However the space & time complexity are O(n^2) because the slice you do has space/time complexity of O(n) |
||
| raise NotImplementedError, "Method not implemented" | ||
| if s.length <= 1 | ||
| return s | ||
| else | ||
| return reverse(s[1..-1]) + s[0] | ||
| end | ||
| end | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # # Time complexity: O(1) | ||
| # # Space complexity: O(1) | ||
| def reverse_inplace(s) | ||
|
Comment on lines
+25
to
27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also you're using the exact method I told you not to use. |
||
| raise NotImplementedError, "Method not implemented" | ||
| if s.length <= 1 | ||
| return s | ||
| else | ||
| return s.reverse! | ||
| end | ||
| end | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # | ||
| # # Time complexity: O(n) | ||
| # # Space complexity: O(n) | ||
| def bunny(n) | ||
| raise NotImplementedError, "Method not implemented" | ||
|
Comment on lines
+35
to
-24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| if n == 0 | ||
| return 0 | ||
| else | ||
| return 2 + bunny(n-1) | ||
| end | ||
| end | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # | ||
| # # Time complexity: O(n^2) * not sure about this one | ||
| # # Space complexity: O(n^2) * same here? | ||
| def nested(s) | ||
|
Comment on lines
+45
to
47
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 Correct! |
||
| raise NotImplementedError, "Method not implemented" | ||
| if s == "" | ||
| return true | ||
| elsif | ||
| s[0] == "(" && s[-1] == ")" | ||
| return nested(s[1..-2]) | ||
| else | ||
| return false | ||
| end | ||
| end | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # | ||
| # # Time complexity: O(n) | ||
| # # Space complexity: O(n^2) | ||
| def search(array, value) | ||
|
Comment on lines
+58
to
60
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This works, but once again the time complexity is O(n^2) |
||
| raise NotImplementedError, "Method not implemented" | ||
| if array.nil? | ||
| return false | ||
| elsif | ||
| array[0] == value | ||
| return true | ||
| else | ||
| return search(array[1..-1], value) | ||
| end | ||
| end | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # | ||
| # # Time complexity: O(n) | ||
| # # Space complexity: O(n) | ||
| def is_palindrome(s) | ||
|
Comment on lines
+71
to
73
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This works, but once again the time complexity is O(n^2) |
||
| raise NotImplementedError, "Method not implemented" | ||
| if s.length <= 1 | ||
| return true | ||
| elsif s[0] != s[-1] | ||
| return false | ||
| else | ||
| return is_palindrome(s[1..-2]) | ||
| end | ||
| end | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # | ||
| # # Time complexity: ? | ||
| # # Space complexity: ? | ||
| def digit_match(n, m) | ||
| raise NotImplementedError, "Method not implemented" | ||
| end | ||
| #Not sure how to get started on this one. | ||
| end | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍