Rachael Water #41
Open
Rachael Water #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Nov 4, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
As you noted you didn't finish all the methods, however the methods you do have complete are mostly working. Take a look at my comments especially regarding ways to do reverse_inplace and how to make the time and space complexities better.
Comment on lines
+5
to
7
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def factorial(n) |
Comment on lines
+15
to
17
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def reverse(s) |
There was a problem hiding this comment.
👍 Given how you have the # frozen_string_literal: true which makes the string fixed and means the slice isn't recreating the string.
Comment on lines
+25
to
27
| # Time complexity: O(n) | ||
| # Space complexity: O(1) | ||
| def reverse_inplace(s) |
Comment on lines
+31
to
33
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def bunny(n) |
Comment on lines
+37
to
+38
| 2 * bunny(n-1) | ||
| return |
There was a problem hiding this comment.
Suggested change
| 2 * bunny(n-1) | |
| return | |
| return 2 + bunny(n-1) |
Comment on lines
45
to
47
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def nested(s) |
Comment on lines
-33
to
59
|
|
||
| # Time complexity: ? | ||
| # Time complexity: O(n) | ||
| # Space complexity: ? | ||
| def search(array, value) |
Comment on lines
+72
to
74
| # Time complexity: O(n^2) | ||
| # Space complexity: O(n^2) | ||
| def is_palindrome(s) |
There was a problem hiding this comment.
👍 , but can you see any way to adjust this to be O(n)?
| def digit_match(n, m) | ||
| raise NotImplementedError, "Method not implemented" | ||
| end | ||
| def digit_match(n, m, num_matches = 0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to have my software developer brother-in-law explain these to me and hopefully have them updated with the correct answers after.