Earth - Anya #35
Open
Earth - Anya #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 27, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Anya, you hit all the learning goals here. Nice use of recursion. I will note that the looping solutions are better in terms of space complexity, but doing it recursively was good practice.
Well done.
Comment on lines
+21
to
23
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Comment on lines
+29
to
+31
| # Time Complexity: O(n) with n being the length of the linked list. | ||
| # Space Complexity: O(n) recursive pushes frames onto call stack for length of list. | ||
| def search(value, current = @head) |
Comment on lines
+39
to
+41
| # Time Complexity: O(n) with n being the length of the linked list. | ||
| # Space Complexity: O(n) | ||
| def find_max(max_value = -1.0/0, current = @head) |
There was a problem hiding this comment.
👍 , interesting way to get - infinity
Comment on lines
+53
to
+55
| # Time Complexity: O(n) with n being the length of the linked list. | ||
| # Space Complexity: O(n) | ||
| def find_min(min_value = 1.0/0, current = @head) |
Comment on lines
+68
to
70
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first |
Comment on lines
+95
to
+97
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def get_at_index(index, current = @head) |
Comment on lines
+104
to
+106
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def visit(current = @head) |
Comment on lines
+113
to
+115
| # Time Complexity: O(n) due to search, delete is O(1) | ||
| # Space Complexity: O(n) | ||
| def delete(value, previous = @head, current = @head) |
Comment on lines
+124
to
+126
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def reverse(current = @head) |
Comment on lines
+135
to
+137
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def get_last(current = @head) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.