Skip to content

[Sync] v2.1.2 Main -> Develop #268

Merged
ThirFir merged 3 commits intodevelopfrom
main
Oct 14, 2025
Merged

[Sync] v2.1.2 Main -> Develop #268
ThirFir merged 3 commits intodevelopfrom
main

Conversation

@ThirFir
Copy link
Collaborator

@ThirFir ThirFir commented Oct 14, 2025

💻 Work Description

  • v2.1.2 업데이트 동기화

Summary by CodeRabbit

  • 버그 수정

    • 로그아웃 또는 계정 삭제 후 앱 재실행 시, 지역 인증과 취향 선택 등 온보딩 단계가 다시 나타나던 문제를 해결했습니다. 불필요한 온보딩 재요청이 발생하지 않아 로그아웃/탈퇴 이후의 사용자 흐름이 더 일관되고 깔끔해졌습니다.
  • Chores

    • 앱 버전을 2.1.2로 업데이트했습니다.

@ThirFir ThirFir self-assigned this Oct 14, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 14, 2025

Walkthrough

UserRepositoryImpl에서 signOut과 deleteAccount의 성공 경로에서 온보딩 상태 업데이트 두 호출이 제거되었고, 프로젝트 버전이 2.1.1 → 2.1.2, 코드 20010010 → 20010020으로 갱신되었습니다.

Changes

Cohort / File(s) Change Summary
Repository 로직 정리
core/data/src/main/kotlin/com/acon/core/data/repository/UserRepositoryImpl.kt
signOut 및 deleteAccount 성공 시 호출되던 onboardingRepository.updateShouldVerifyArea(true)onboardingRepository.updateShouldChooseDislikes(true) 제거
버전 업데이트
gradle/libs.versions.toml
projectVersionName 2.1.1 → 2.1.2, projectVersionCode 20010010 → 20010020

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant R as UserRepositoryImpl
  participant A as AuthService
  %% participant O as OnboardingRepository  %% (이전: 호출 존재)

  rect rgba(200,230,255,0.25)
  U->>R: signOut()
  R->>A: signOut()
  A-->>R: Success/Failure
  alt Success
    note right of R: (변경) 온보딩 업데이트 호출 제거
    R-->>U: Completed
  else Failure
    R-->>U: Error
  end
  end

  rect rgba(200,255,200,0.25)
  U->>R: deleteAccount()
  R->>A: deleteAccount()
  A-->>R: Success/Failure
  alt Success
    note right of R: (변경) 온보딩 업데이트 호출 제거
    R-->>U: Completed
  else Failure
    R-->>U: Error
  end
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

폴짝! 버전 한 칸, 2.1.2로 점프해요 🥕
로그아웃 길 정돈, 불필요 호출 쏙—정리 완료!
탈퇴도 산뜻, 바람처럼 가벼워졌지요.
깡충깡충 코드밭, 당근 깃발 휘날리네.
오늘도 리듬 타는 빌드, 띵- 완료!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed PR 제목 “[Sync] v2.1.2 Main -> Develop”은 메인 브랜치에서 develop 브랜치로 v2.1.2 업데이트를 동기화한다는 주된 변경사항을 간결하게 표현하고 있어 변경 내용과 잘 부합합니다.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch main

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b994499 and 23534a9.

📒 Files selected for processing (2)
  • core/data/src/main/kotlin/com/acon/core/data/repository/UserRepositoryImpl.kt (0 hunks)
  • gradle/libs.versions.toml (1 hunks)
💤 Files with no reviewable changes (1)
  • core/data/src/main/kotlin/com/acon/core/data/repository/UserRepositoryImpl.kt
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: ThirFir
PR: AconInc/ACON-Android#261
File: core/ads/src/main/java/com/acon/core/ads/SpotListAdProvider.kt:118-120
Timestamp: 2025-09-25T05:00:34.014Z
Learning: ThirFir validates implementations through actual testing and prefers test-proven solutions over theoretical concerns, especially when the theoretical issue doesn't manifest in real-world usage.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build
  • GitHub Check: build
  • GitHub Check: build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ThirFir ThirFir merged commit c9529e4 into develop Oct 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments