Fix battlerage skill ordering and add dynamic skill list output #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update modifies the script to handle the recent Achaea update where all classes now have seven battlerage abilities instead of six. The original script assumed only six and failed to parse or use the abilities properly. Summary of Changes: Updated all index references to battlerageSkills (e.g. 1 → 2, 3 → 4, 4 → 5, etc.). Adjusted rageRazeFunction, simple, and simplereverse battlerage strategies to reflect new skill positions. Modified class-specific battlerage sorting functions (sortPariahBattlerage, etc.) to assign skills to the new correct indexes. Rewrote knownBattlerageSkillList() to dynamically list all available battlerage skills instead of hardcoding 6. This should restore correct battlerage execution and allow the system to scale if future battlerage abilities are added.
This update improves battlerage skill handling following the addition of a new skill (e.g., provoke) by Achaea. Instead of rewriting index logic, the update adjusts the skill ordering dynamically to preserve existing behavior. Summary: sortProvokeBattlerage() added Detects if provoke is the first battlerage skill (as currently sent by Achaea) and moves it to the end of the skill list, maintaining expected indexing for existing battlerage strategies. Called sortProvokeBattlerage() after all class-based sorters Ensures skill order is corrected regardless of class. Updated knownBattlerageSkillList() to use dynamic iteration Now lists all known battlerage skills by name, regardless of total count, avoiding hardcoded index errors. These changes preserve all original functionality while gracefully handling future battlerage expansions.
This update improves battlerage skill handling following the addition of a new skill (e.g., provoke) by Achaea. Instead of rewriting index logic, the update adjusts the skill ordering dynamically to preserve existing behavior. Summary: sortProvokeBattlerage() added Detects if provoke is the first battlerage skill (as currently sent by Achaea) and moves it to the end of the skill list, maintaining expected indexing for existing battlerage strategies. Called sortProvokeBattlerage() after all class-based sorters Ensures skill order is corrected regardless of class. Updated knownBattlerageSkillList() to use dynamic iteration Now lists all known battlerage skills by name, regardless of total count, avoiding hardcoded index errors. These changes preserve all original functionality while gracefully handling future battlerage expansions.
Added correct updated file
local variable for set battlerage skill value for easy changes if more are added later
keneanung
approved these changes
Jul 16, 2025
Member
keneanung
left a comment
keneanung
left a comment
There was a problem hiding this comment.
thanks for the work and the patience!
Forgot Depthswalker change
keneanung
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Achaea's recent update added a new battlerage skill (e.g., provoke) that now appears first in the skill list via GMCP. This breaks existing logic that expects skill positions to remain unchanged.
Changes:
Added sortProvokeBattlerage() to detect when provoke is the first skill and move it to the end of battlerageSkills.
Called sortProvokeBattlerage() after all class-specific sorting functions.
Rewrote knownBattlerageSkillList() to dynamically list all known battlerage skill names, future-proofing the output.
This avoids the need to change all index references and preserves compatibility with current battlerage strategies.