remove the pattern plain: from gerrit trigger!#47
Open
khozema-nullwala wants to merge 1 commit intoAccenture:masterfrom
Open
remove the pattern plain: from gerrit trigger!#47khozema-nullwala wants to merge 1 commit intoAccenture:masterfrom
khozema-nullwala wants to merge 1 commit intoAccenture:masterfrom
Conversation
randyspiess
approved these changes
Nov 12, 2019
Contributor
|
Thanks @khozema-nullwala and @randyspiess for your contribution. However, our CI / CD tests (running in Travis) are failing. Would you be able to correct this too? Looks like openjdk7 and 8 are no longer available in Travis. Once Travis is passing, I'm happy to merge these changes as I can see in the Pluggable SCM provider code base here where the gerrit provider trigger methods lives it also appends "plain:" which would result in plain:plain:master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
In the DevOps Academy session while running through Module - 02 lab activity the build job does not gets trigger.
Removing the plain: from the gerrit trigger pattern of Reference Application Build job then after saving changes to this job it gets executed on code push done to master branch.