Adding age to session and add a way to delete old session on page load #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max age for session is set to 3600
…ashing from having no model info
tpfau
reviewed
Sep 22, 2025
task_template/app/routers/session.py
Outdated
| ): | ||
| sessionID = session.id | ||
| if sessionID in sessions: | ||
| queue_handler.remove_response_queue(sessionID) |
Member
There was a problem hiding this comment.
I'd recommend calling
Suggested change
| queue_handler.remove_response_queue(sessionID) | |
| queue_handler.clear_session(sessionID) |
Also, I would put this into the task_router as a "/start" endpoint (corresponding to "/finish").
And, it would probably be good, if we ensure, that other endpoints don't work if there is no session, with only this endpoint creating sessions. This is not strictly necessary, but would make sure, that all Tasks act somewhat similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've added a way to guarantee that the user get a fresh session on page load: the page will call the get endpoint in the router file to check whether the session id is already in the session dictionary or not. Also, I've added the age for the session as 3600 seconds. Could you take a look to check if I missed something or got something wrong. Thanks!