Proposal for GetSystemTime by AStasiuk · Pull Request #1 · AStasiuk/sdl_evolution

AStasiuk · 2017-11-07T13:15:54Z

[In creating a Pull Request for SDL Evolution, please note the following guidelines:

Please make the title of your pull request the exact title of your proposal.
Please make the text of your pull request the exact text of the introduction of your proposal.
Please make a new comment (do not do this in the initial text) notifying @theresalech that the proposal is ready for review when you wish to make no more changes and for the SDLC Steering Committee to consider reviewing your pull request. It will not be considered for review until you have done so.
Please follow the template and fill out the metadata at the top properly.
Please make sure your proposal is clear for reviewers to read, keeping in mind that the majority of reviewers are English-speaking. Proposals should be formatted per the templates and guidelines provided, including the rules in (4). Once you have asked for a "review ready" tag, the project maintainers will quickly skim your proposal and note obvious errors that need to be fixed. The maintainers are not to be relied upon to catch all errors. The Steering Committee may push back on misformatted proposals or decide not to review a proposal until it is formatted properly and easily read. Please make sure your proposals are in a "final" state before requesting review!

Please delete the above section when you have read it.]

dev-gh · 2017-11-07T14:11:20Z

proposals/NNNN-GetSystemTime.md

+
+## Introduction
+
+This proposal is about adding a new RPC GetSystemTime to SDL Core for correct receiving of system time.


@AStasiuk
The sole purpose of this RPC is to get real system time during TLS handshake but not time correction.

@dev-gh Fixed in 280d2cb

dev-gh · 2017-11-07T14:13:20Z

proposals/NNNN-GetSystemTime.md

+
+## Motivation
+
+Allow SDL Core obtain time from the system in UTC format. Exclude possibility of UTC time distortion in case using system time from other components of the system.


@AStasiuk
Motivation here is that SDL does not have access to the real system time so we need an interface to the system in order to request it when it is required.

@dev-gh Fixed in 280d2cb

dev-gh · 2017-11-07T14:15:53Z

proposals/NNNN-GetSystemTime.md

+## Proposed solution
+
+
+The solution proposes adding new RPC between SDL and HMI.  GetSystemTime gives possibility to get the System Time status by making the following additions to the HMI API.


@AStasiuk

just 'system time' or 'real system time', no need to say that aloud )

better ".. by introducing new API.." or ".. extending HMI API with.."

@dev-gh Fixed in 280d2cb

dev-gh · 2017-11-07T14:17:11Z

proposals/NNNN-GetSystemTime.md

+
+The solution proposes adding new RPC between SDL and HMI.  GetSystemTime gives possibility to get the System Time status by making the following additions to the HMI API.
+
+SDL Core must send this GetSystemTime RPC to HMI in case of Policy Table Update procedure and before Security TLS Handshake.


@AStasiuk
As far as I know time is not needed for policy update, but policy update is needed in case there is no certificate on the system, than system time will be required to finish handshake

@dev-gh Fixed in 280d2cb

dev-gh · 2017-11-07T14:18:03Z

proposals/NNNN-GetSystemTime.md

+
+SDL Core must send this GetSystemTime RPC to HMI in case of Policy Table Update procedure and before Security TLS Handshake.
+
+Expected that HMI will request system time from the system and provide to SDL Core via GetSystemTime_response


@AStasiuk

better is "Expected that HMI will provide real system time with GetSystemTime response"

@dev-gh Fixed in 280d2cb

dev-gh · 2017-11-07T14:20:38Z

proposals/NNNN-GetSystemTime.md

+
+Requires changes on SDL core,  and HMI_API.
+
+Would require a major version change.


@AStasiuk
I think it should be in "potential downsides"

@dev-gh Rejected, I don't see these issues as "potential downsides".

dev-gh · 2017-11-07T14:21:40Z

proposals/NNNN-GetSystemTime.md

+
+## Alternatives considered
+
+Using mqueue signals mechanism.


@AStasiuk
Not only mqueue but any other like pipes, mqueue, shared memory etc.

@dev-gh Fixed in 280d2cb

AKalinich-Luxoft · 2017-11-07T14:31:50Z

proposals/NNNN-GetSystemTime.md

+## Proposed solution
+
+
+The solution proposes adding new RPC between SDL and HMI.  GetSystemTime gives possibility to get the System Time status by making the following additions to the HMI API.


@AStasiuk suggest to rephrase:
New GetSystemTime RPC could be added to extend communication between SDL and HMI. This RPC gives possibility...

@AKalinich-Luxoft Fixed in 280d2cb

AKalinich-Luxoft · 2017-11-07T14:33:17Z

proposals/NNNN-GetSystemTime.md

+
+The solution proposes adding new RPC between SDL and HMI.  GetSystemTime gives possibility to get the System Time status by making the following additions to the HMI API.
+
+SDL Core must send this GetSystemTime RPC to HMI in case of Policy Table Update procedure and before Security TLS Handshake.


@AStasiuk during Policy Table Update sequence and before Security SSL Handshake

@AKalinich-Luxoft Fixed in 475a8bf

AKalinich-Luxoft · 2017-11-07T14:34:21Z

proposals/NNNN-GetSystemTime.md

+
+SDL Core must send this GetSystemTime RPC to HMI in case of Policy Table Update procedure and before Security TLS Handshake.
+
+Expected that HMI will request system time from the system and provide to SDL Core via GetSystemTime_response


@AStasiuk please remove underscope in GetSystemTime_response

@AKalinich-Luxoft Fixed in 475a8bf

dev-gh · 2017-11-08T08:05:36Z

proposals/NNNN-GetSystemTime.md

+
+## Motivation
+
+Now SDL Core does not have access to the real system time so  need an interface to the system in order to request it when it is required 


@AStasiuk
I think its better to clarify that "in some cases SDL may not have access to the real system time" as it depends on a platform SDL is integrated to.

@dev-gh Fixed in 5bc9300

dev-gh · 2017-11-08T08:07:03Z

proposals/NNNN-GetSystemTime.md

+
+The solution proposes adding new RPC between SDL and HMI.  GetSystemTime gives possibility to get the real system time status by introducing new API.
+
+SDL Core must send this GetSystemTime RPC to HMI in case of Policy Table Update sequence - in case there is no certificate on the system.  Than system time will be required to finish Security TLS Handshake.


@AStasiuk
My previous comment basically mention policy update just to make it more clear for you but I don't think it has to be mentioned in proposal as policy update has nothing to do with system time

@dev-gh Fixed in 5bc9300

…icle-data-turnSignal.md

autoCL on my branch for OpenSDL

…udio-streaming-indicator.md

…qt-hmi-from-sdl-core.md

* Add nnnn-ios-carwindow * Update nnnn-ios-carwindow.md * Update nnnn-ios-carwindow.md * Update nnnn-ios-carwindow.md

…s-concurrent-rpc-notifications.md

* Add audio stream manager proposal * Update nnnn-audiostreammanager.md * Update nnnn-audiostreammanager.md

…er.md

* Create nnnn-default-softbuttoncapabilities.md * Update nnnn-default-softbuttoncapabilities.md * Update nnnn-default-softbuttoncapabilities.md * Update nnnn-default-softbuttoncapabilities.md * Update nnnn-default-softbuttoncapabilities.md * Update nnnn-default-softbuttoncapabilities.md

…/0114-default-softbuttoncapabilities.md

Update status for 0105, 0107, 0108, 0110. Add 0111, 0112, 0113, 0114.

Update NNNN-GetSystemTime.md according to review

dev-gh reviewed Nov 7, 2017

View reviewed changes

AKalinich-Luxoft requested changes Nov 7, 2017

View reviewed changes

aderiabin approved these changes Nov 7, 2017

View reviewed changes

AKalinich-Luxoft approved these changes Nov 7, 2017

View reviewed changes

GetmanetsIrina approved these changes Nov 8, 2017

View reviewed changes

dev-gh reviewed Nov 8, 2017

View reviewed changes

dev-gh approved these changes Nov 8, 2017

View reviewed changes

robinmk and others added 23 commits November 8, 2017 10:52

Create NNNN-New-vehicle-data-turnSignal.md (smartdevicelink#316)

b28a9c1

Update and rename NNNN-New-vehicle-data-turnSignal.md to 0107-New-veh…

eadffa2

…icle-data-turnSignal.md

Created ACL (smartdevicelink#317)

759240b

autoCL on my branch for OpenSDL

Update and rename NNNN-AutoCompleteList.md to 0108-AutoCompleteList.md

b460ebb

Pushed proposal for SetAudioSreamingIndicator RPC (smartdevicelink#318)

cd94080

Update and rename NNNN-set-audio-streaming-indicator.md to 0109-set-a…

cc453b5

…udio-streaming-indicator.md

Create NNNN-remove-qt-hmi-from-sdl-core.md (smartdevicelink#323)

9f7d93f

Update and rename NNNN-remove-qt-hmi-from-sdl-core.md to 0110-remove-…

04903f6

…qt-hmi-from-sdl-core.md

Add 0107, 0108, 0109, 0110

ec737c5

Update 0105-remote-control-seat.md

451d01b

Update Status

03628bd

Update status

e948019

Update status

a47a370

SDLCarWindow (smartdevicelink#338)

94b3bfa

* Add nnnn-ios-carwindow * Update nnnn-ios-carwindow.md * Update nnnn-ios-carwindow.md * Update nnnn-ios-carwindow.md

Update and rename nnnn-ios-carwindow.md to 0111-ios-carwindow.md

986e1d0

Add nnnn-ios-concurrent-rpc-notifications.md (smartdevicelink#339)

d43e9e7

Update and rename nnnn-ios-concurrent-rpc-notifications.md to 0112-io…

7f103f8

…s-concurrent-rpc-notifications.md

SDLAudioStreamManager (smartdevicelink#343)

cae7900

* Add audio stream manager proposal * Update nnnn-audiostreammanager.md * Update nnnn-audiostreammanager.md

Update and rename nnnn-audiostreammanager.md to 0113-audiostreammanag…

deab6fc

…er.md

Update and rename nnnn-default-softbuttoncapabilities.md to proposals…

c1d595b

…/0114-default-softbuttoncapabilities.md

Update status and add proposals.

50fe379

Update status for 0105, 0107, 0108, 0110. Add 0111, 0112, 0113, 0114.

This is a combination of 13 commits.

19088cd

Update NNNN-GetSystemTime.md according to review

AStasiuk force-pushed the feature/GetSystemTime branch from d388f2f to 19088cd Compare November 20, 2017 08:57

Update typos.

bbe0f41


		## Introduction

		This proposal is about adding a new RPC GetSystemTime to SDL Core for correct receiving of system time.


		## Motivation

		Allow SDL Core obtain time from the system in UTC format. Exclude possibility of UTC time distortion in case using system time from other components of the system.

		## Proposed solution


		The solution proposes adding new RPC between SDL and HMI. GetSystemTime gives possibility to get the System Time status by making the following additions to the HMI API.


		The solution proposes adding new RPC between SDL and HMI. GetSystemTime gives possibility to get the System Time status by making the following additions to the HMI API.

		SDL Core must send this GetSystemTime RPC to HMI in case of Policy Table Update procedure and before Security TLS Handshake.


		SDL Core must send this GetSystemTime RPC to HMI in case of Policy Table Update procedure and before Security TLS Handshake.

		Expected that HMI will request system time from the system and provide to SDL Core via GetSystemTime_response


		Requires changes on SDL core, and HMI_API.

		Would require a major version change.


		## Motivation

		Now SDL Core does not have access to the real system time so need an interface to the system in order to request it when it is required

Conversation

AStasiuk commented Nov 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AStasiuk Nov 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AStasiuk Nov 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Comments

AStasiuk Nov 8, 2017 •

edited

Loading

AStasiuk Nov 8, 2017 •

edited

Loading