remove vagrant stuff, pointing towards WSL2 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajharvie
requested review from
NGRhodes,
TEHardcastle,
Tiany1Pan,
agdturner,
murphyqm,
ollie-clark and
sharriet
Contributor
Author
|
Also, have just updated the actions so they'll pass! |
murphyqm
reviewed
Nov 21, 2024
| pull_request: | ||
| branches: | ||
| - main | ||
| workflow_dispatch: |
There was a problem hiding this comment.
10/10 support always having a workflow_dispatch option for rebuilding on the fly, saves so many spurious commits.
murphyqm
approved these changes
Nov 21, 2024
murphyqm
left a comment
murphyqm
left a comment
There was a problem hiding this comment.
Tested that build works smoothly locally; all seems right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggesting use of WSL2 (as recommended by official docs) over vagrant/VM solution for use on Windows