This repository was archived by the owner on Dec 11, 2020. It is now read-only.
allow chaning service endpoint inside the middleware#19
Open
Conversation
* added `request.endpoint` which carries the service endpoint * brainslug middleware uses `request.endpoint` to make the final request I'm not very happy with the `request.endpoint`. I would prefer some global object, a service for example. So it would be `service.endpoint`. But it is much harder to implement. Will give it some time to rest and see.
|
very useful |
Contributor
Author
|
@galenzhao have you tried it? Even if I merge it to master, I'm not sure when I'll be able to do a release. The release happens from on-premise branch anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request.endpointwhich carries the service endpointrequest.endpointto make the final requestI'm not very happy with the
request.endpoint. I would prefer someglobal object, a service for example. So it would be
service.endpoint.But it is much harder to implement. Will give it some time to rest and
see.
allows to change endpoint on the fly in the middleware like:
fixes #18