feat: add proc label to issues#223
Merged
amd-aliem merged 2 commits intoAMDEPYC:mainfrom Jan 16, 2026
Merged
Conversation
Contributor
|
For this one, there’s one point I’d like to discuss first. It may make sense to move the processor-type discovery outside of Beacon-Report. The reasoning is that this information will be used for more than just populating issues. It will also be needed to gate or “unblock” processor-specific tests as those are added, and to report the processor model in the generated certificates. Given those additional use cases, it might be better to adjust the processor discovery logic here so it’s more forward-looking and reusable across the project. |
c937f9a to
e11fbdb
Compare
Signed-off-by: Amanda Liem <aliem@amd.com>
Contributor
Author
|
@DGonzalezVillal ready for re-review! Created new module w/ the python snippet you gave me extended. Added a |
DGonzalezVillal
approved these changes
Jan 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #218: Add
proc-XxxXlabels for processor generation.New module added -
proc-model, which has a new script that can return the host machine'scodename(i.e. Genoa/Milan), or itsseries(i.e. 7004, 9005).example issue created during test: amd-aliem#75