Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
… in `wp_setup_nav_menu_item()`. The `get_post_states()` function is also hardened to short-circuit in case a non-`WP_Post` is passed. A test is added to verify this. Developed in #10706 Follow-up to [47211]. Props apedog, josephscott, joemcgill, westonruter. See #49374. Fixes #58932. git-svn-id: https://develop.svn.wordpress.org/trunk@61465 602fd350-edb4-49c9-b593-d223f7449a82
…s_active_widget()`. This avoids a possible PHP warning due to an undefined array key. Developed in #10710 Follow-up to [11090], [7080]. Props sageth, josephscott, Ipstenu, mindctrl, westonruter. See #8441, #6023. Fixes #57518. git-svn-id: https://develop.svn.wordpress.org/trunk@61466 602fd350-edb4-49c9-b593-d223f7449a82
`wp_kses_hair()` is built around an impressive state machine for parsing the span of text following an HTML tag name and the tag’s closing `>` into a structured representation of the attributes. Unfortunately that parsing code doesn’t comply with the HTML Living Standard and is prone to mis-parsing attributes, particularly in the presence of malformed inputs. This patch replaces the existing state machine with the spec-compliant parsing from the HTML API. With a comprehensive test suite covering attribute parsing, the same reliability the Tag Processor affords will be applied to `wp_kses_hair()`, giving new guarantees not previously available in Core: - All attribute values are reported fully-normalized, where character references are decoded and then re-encoded in a predictable manner. Only the “big five” syntax characters (“&<>'"”) will remain, and in their named forms. - All `whole` values are fully normalized and presented either as boolean attributes without a value, or with double-quoted attribute values. - All attributes and their values will be properly parsed according to how a browser would parse them, bringing agreement between the server and user agents. Developed in #9248 Discussed in https://core.trac.wordpress.org/ticket/63724 Props adamziel, dmsnell, jonsurrell, jorbin, westonruter. Fixes #63724. git-svn-id: https://develop.svn.wordpress.org/trunk@61467 602fd350-edb4-49c9-b593-d223f7449a82
The latest version: * Includes a fix for `sendmail` parameter problems in WordPress. * Reduces memory consumption when sending large attachments. References: * [https://github.com/PHPMailer/PHPMailer/releases/tag/v7.0.2 PHPMailer 7.0.2 release notes] * [PHPMailer/PHPMailer@v7.0.0...v7.0.2 Full list of changes in PHPMailer 7.0.2] Follow-up to [54937], [55557], [56484], [57137], [59246], [59481], [60623], [60813], [60888], [61249]. Props SirLouen, robinvandervliet, desrosj, siliconforks, digitalblanket, studiomondiale, jorbin, westonruter, dmsnell, zoe20, Monarobase, amanandhishoe, SergeyBiyrukov. Fixes #64491. See #64368. git-svn-id: https://develop.svn.wordpress.org/trunk@61468 602fd350-edb4-49c9-b593-d223f7449a82
… link instead of JavaScript. * The skip link now works when JavaScript is turned off. * By removing the script, the amount of JavaScript sent to the client is reduced for a very marginal performance improvement. * A new `wp-block-template-skip-link` stylesheet is registered, with minification and `path` data for inlining. * The CSS for the skip link now has an RTL version generated, although it is not yet served when the styles are inlined. See #61625. * The `wp_enqueue_block_template_skip_link()` function now exclusively enqueues the stylesheet since the script is removed. * For backwards-compatibility, the skip link will continue to be omitted if `the_block_template_skip_link()` is unhooked from the `wp_footer` action or `wp_enqueue_block_template_skip_link()` is unhooked from `wp_enqueue_scripts`. Developed in #10676 Follow-up to [56932], [51003]. Props rutviksavsani, westonruter, dmsnell, whiteshadow01, Slieptsov. See #59505, #53176. Fixes #64361. git-svn-id: https://develop.svn.wordpress.org/trunk@61469 602fd350-edb4-49c9-b593-d223f7449a82
…ator. Developed in #10703 Follow-up to [61464], [61463], [61457], [61456], [61455], [61454], [61453], [61445], [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props soean, westonruter, mukesh27. See #58874. Fixes #64488. git-svn-id: https://develop.svn.wordpress.org/trunk@61470 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [56300]. Props sabernhardt, flixos90, luisherranz, gautam23, huzaifaalmesbah, mukesh27, r1k0, SergeyBiryukov. Fixes #60111. git-svn-id: https://develop.svn.wordpress.org/trunk@61471 602fd350-edb4-49c9-b593-d223f7449a82
The function was removed in [61438] but should have been deprecated instead of removed outright, per WordPress backward compatibility policy. Hot reloading is not used anymore in the latest Gutenberg build tool. Props peterwilsoncc, westonruter. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61472 602fd350-edb4-49c9-b593-d223f7449a82
Enable Global Styles functionality in classic WordPress themes, allowing features like the Font Library to work without requiring a theme.json file. This change: - Removes restrictions that prevented classic themes from accessing Global Styles features. - Enables font functionality in classic themes through the Font Library. - Fixes Fonts menu not appearing in classic themes by changing its submenu index to avoid collision with Widgets. Props youknowriad, isabel_brison, ramonopoly. Fixes #64408. git-svn-id: https://develop.svn.wordpress.org/trunk@61473 602fd350-edb4-49c9-b593-d223f7449a82
…on logic. Some replaced instances also fix a bug where the comparison function should have returned `0` as opposed to `1` or `-1` as used in ternaries. This results in a performance improvement. Developed in #10717 Props soean, mukesh27, westonruter. Fixes #64497. git-svn-id: https://develop.svn.wordpress.org/trunk@61474 602fd350-edb4-49c9-b593-d223f7449a82
This aims to avoid a `JavaScript heap out of memory` fatal error when running `npm run dev`. Follow-up to [25001]. Props SirLouen, desrosj, tusharbharti, ankitkumarshah, SergeyBiryukov. Fixes #63606. git-svn-id: https://develop.svn.wordpress.org/trunk@61475 602fd350-edb4-49c9-b593-d223f7449a82
Adds `svn:ignore` entries for Gutenberg-generated files that were added to `.gitignore` in [61438]. The following entries were added: * Root directory: `gutenberg` * `src/wp-includes`: `blocks`, `build`, `class-wp-block-parser-block.php`, `class-wp-block-parser-frame.php`, `theme.json` Props peterwilsoncc. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61476 602fd350-edb4-49c9-b593-d223f7449a82
When setting JavaScript or JSON script tag content, automatically escape sequences like `<script>` and `</script>`. This renders the content safe for HTML. The semantics of any JSON and virtually any JavaScript are preserved. Script type detection follows the HTML standard for identifying JavaScript and JSON script tags. Other script types continue to reject potentially dangerous content. Developed in #10635. Props jonsurrell, dmsnell, westonruter. Fixes #64419. See #63851, #51159. git-svn-id: https://develop.svn.wordpress.org/trunk@61477 602fd350-edb4-49c9-b593-d223f7449a82
The `assertEqualHTML()` method makes tests resilient to irrelevant syntactic changes in HTML output, focusing on semantic equivalence rather than exact string matching. Developed in #10727. Follow up to [61394], [61391]. Props jonsurrell, cbravobernal. See #64225. git-svn-id: https://develop.svn.wordpress.org/trunk@61478 602fd350-edb4-49c9-b593-d223f7449a82
Restores the `$is_block_theme` check that was inadvertently removed in [61473]. This ensures that for classic themes, the Customizer's Additional CSS continues to be printed separately via `wp_custom_css_cb()` at priority 101 in `wp_head`, preserving its position at the end of the `<head>` for highest CSS specificity. Follow-up to [61473]. Props westonruter. Fixes #64408. git-svn-id: https://develop.svn.wordpress.org/trunk@61479 602fd350-edb4-49c9-b593-d223f7449a82
In modern browsers the CSS `content` property provides alt text support for assistive technology in the form `display / alt text`. This introduces support for legacy browsers that do not support the new syntax.
CSS content properties take advantage of the CSS cascade and browsers ignoring values they don't understand by adding duplicate `content` properties in the form:
{{{#!css
content: display;
content: display / alt text;
}}}
Modern browsers will use the second property, legacy browsers will use the first.
Follow-up to [60885] for #63603.
Props acmoifr, joedolson, jorbin, mydesign78, ov3rfly, peterwilsoncc, presskopp, sabernhardt, siliconforks, swissspidy, threadi, wildworks, wolf45.
Fixes #64350.
git-svn-id: https://develop.svn.wordpress.org/trunk@61480 602fd350-edb4-49c9-b593-d223f7449a82
…n array. This aims to avoid a fatal error if the array was somehow corrupted and contains non-numeric values. Follow-up to [8049]. Props umeshsinghin, azora, sabernhardt, deepakrohilla, narenin, SergeyBiryukov. Fixes #62542. git-svn-id: https://develop.svn.wordpress.org/trunk@61481 602fd350-edb4-49c9-b593-d223f7449a82
Add tests that verify the behavior of `wp_get_inline_script_tag()` and `wp_get_script_tag()` attribute handling. Developed in #10728. Props jonsurrell, dmsnell. See #64500. git-svn-id: https://develop.svn.wordpress.org/trunk@61482 602fd350-edb4-49c9-b593-d223f7449a82
…es()`. Follow-up to [61032]. Props hbhalodia. See #64098. Fixes #64503. git-svn-id: https://develop.svn.wordpress.org/trunk@61483 602fd350-edb4-49c9-b593-d223f7449a82
…`null`. This adds a check that the `$current_screen` global is not only defined, but also has the correct type. Follow-up to [15746]. Props marian1, mayanktripathi32, abcd95, im3dabasia1, SergeyBiryukov. Fixes #62562. git-svn-id: https://develop.svn.wordpress.org/trunk@61484 602fd350-edb4-49c9-b593-d223f7449a82
Script tags have complicated and unintuitive parsing rules that make them difficult to author correctly. The HTML API automatically escapes script tag contents as necessary and will set attributes correctly. Using the HTML API to generate SCRIPT tags improves safety when working with SCRIPT tags, resolving a class of issues that have manifested repeatedly. Changeset [61418] applied the HTML API to generate style tags in a similar way. Developed in #10639. Props jonsurrell, dmsnell, westonruter. Fixes #64500. See #64419, #40737, #62797, #63851, #51159. git-svn-id: https://develop.svn.wordpress.org/trunk@61485 602fd350-edb4-49c9-b593-d223f7449a82
Relax Global Styles custom CSS filters to allow arbitrary CSS. Escape HTML characters `<>&` in Global Styles data to prevent it from being mangled by post content filters. The data is JSON encoded and stored in `post_content`. Filters operating on `post_content` expect it to contain HTML. Some KSES filters would otherwise remove essential CSS features like the `<custom-ident>` CSS data type because they appear to be HTML tags. [61418] changed STYLE tag generation to use the HTML API for improved safety. Developed in #10641. Props jonsurrell, dmsnell, westonruter, ramonopoly, oandregal, jorgefilipecosta, sabernhardt, soyebsalar01. See #64418. git-svn-id: https://develop.svn.wordpress.org/trunk@61486 602fd350-edb4-49c9-b593-d223f7449a82
Restores the `wp_register_development_scripts()` function and associated build infrastructure to enable hot module replacement (HMR) when using `@wordpress/scripts` with the `--hot` flag. The React Refresh scripts were removed in [61438] as part of the Gutenberg build restructuring, but they are still needed for plugin developers using `wp-scripts start --hot` for block development. Props jsnajdr, wildworks, manzoorwanijk. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61487 602fd350-edb4-49c9-b593-d223f7449a82
Adds the missing `tools/webpack/development.js` file that was inadvertently omitted from [61487]. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61488 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [35189], [35629], [35772], [61656]. See #64225. git-svn-id: https://develop.svn.wordpress.org/trunk@61714 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [661/tests], [45929]. Props rahmohn. See #64225. git-svn-id: https://develop.svn.wordpress.org/trunk@61715 602fd350-edb4-49c9-b593-d223f7449a82
…id`. This fixes a PHPStan rule level 3 error: `return.empty`. Developed in #10995 Props huzaifaalmesbah, westonruter, shailu25, mukesh27, noruzzaman. See #64238. git-svn-id: https://develop.svn.wordpress.org/trunk@61716 602fd350-edb4-49c9-b593-d223f7449a82
Developed in #10963 Props noruzzaman, westonruter, huzaifaalmesbah. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61717 602fd350-edb4-49c9-b593-d223f7449a82
…t_custom()`. Developed in #10996 Follow-up to [52795]. Props ravikhadka, westonruter, swissspidy, roytanck. See #64224, #55249. Fixes #60646. git-svn-id: https://develop.svn.wordpress.org/trunk@61718 602fd350-edb4-49c9-b593-d223f7449a82
Developed in #10999 Follow-up to r32598. Props apermo, mukesh27, westonruter See #64238. Fixes #64694. git-svn-id: https://develop.svn.wordpress.org/trunk@61719 602fd350-edb4-49c9-b593-d223f7449a82
Fix templates in Twenty Twenty Five that have multiple query posts with offsets to prevent displaying sticky posts. Sticky posts being enabled on multiple queries results in repeated content in each query. Add `"sticky":"ignore"` to query block parameters. Props poena, sabernhardt, abcd95, rinkalpagdar, freibergergarcia, akshat2802, mindctrl, ozgursar, joedolson. Fixes #62975. git-svn-id: https://develop.svn.wordpress.org/trunk@61720 602fd350-edb4-49c9-b593-d223f7449a82
This matches the documented `bool` return type to indicate the feature support was successfully removed. Follow-up to [20212]. Props huzaifaalmesbah. See #64238. git-svn-id: https://develop.svn.wordpress.org/trunk@61721 602fd350-edb4-49c9-b593-d223f7449a82
Renames the option `enable_real_time_collaboration` to `wp_enable_real_time_collaboration` to include the prefix as has been the practice for new options since WordPress 5.8.0. Props peterwilsoncc, mukesh27, parthvataliya, czarate. See #64622. git-svn-id: https://develop.svn.wordpress.org/trunk@61722 602fd350-edb4-49c9-b593-d223f7449a82
…ate_Query` docblocks. Props truptikanzariya. Fixes #64713. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61723 602fd350-edb4-49c9-b593-d223f7449a82
See #64713, #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61724 602fd350-edb4-49c9-b593-d223f7449a82
The relevant files will be scanned within `src` (provided the build script has been run). See #64394. git-svn-id: https://develop.svn.wordpress.org/trunk@61726 602fd350-edb4-49c9-b593-d223f7449a82
…()`. This reflects that the method can return both `true` (success) and `false` (failure). Follow-up to [32620], [34089], [44941]. Props huzaifaalmesbah, westonruter. See #64238. git-svn-id: https://develop.svn.wordpress.org/trunk@61727 602fd350-edb4-49c9-b593-d223f7449a82
Fix the icon alignment in the welcome panel close button following the admin reskin. Props mohitbsf, opurockey, huzaifaalmesbah, joedolson. Fixes #64681. git-svn-id: https://develop.svn.wordpress.org/trunk@61728 602fd350-edb4-49c9-b593-d223f7449a82
Following the admin reskin, the larger buttons in plugin cards caused an existing potential for text overlap to happen more easily. Switching to compact size restores prior behavior. Props hiroshisato, audrasjb, huzaifaalmesbah, shailu25, joedolson. Fixes #64686. git-svn-id: https://develop.svn.wordpress.org/trunk@61729 602fd350-edb4-49c9-b593-d223f7449a82
Following the admin reskin, the Copy link button for sharing customizer previews was misaligned. Override core button disabled styles to set transform and background properties. Fix shadow height. Props mohitbsf, audrasjb, hbhalodia, huzaifaalmesbah, sajib1223, joedolson. Fixes #64688. git-svn-id: https://develop.svn.wordpress.org/trunk@61730 602fd350-edb4-49c9-b593-d223f7449a82
This changeset backports the changes made to common notices to `login.css`. Props juanfra, huzaifaalmesbah, shailu25, joedolson. Fixes #64715. git-svn-id: https://develop.svn.wordpress.org/trunk@61731 602fd350-edb4-49c9-b593-d223f7449a82
…dget. This changeset standardizes the vertical spacing between the heading and the first content item in the “At a Glance” admin dashboard widget to match the spacing conventions used by other dashboard widgets. Props mohitbsf, opurockey, adnanhyder. Fixes #64682. git-svn-id: https://develop.svn.wordpress.org/trunk@61732 602fd350-edb4-49c9-b593-d223f7449a82
…velopment environment. The `wp_install_maybe_enable_pretty_permalinks()` function usually enables pretty permalinks during installation, but it relies on a loopback request that may not work on all development environments. In temporary lieu of fixing the underlying loopback request on all the container images, this switches to explictly enabling permalinks and removes redundant permalink configuration from GitHub Actions workflow files. See #64227 git-svn-id: https://develop.svn.wordpress.org/trunk@61733 602fd350-edb4-49c9-b593-d223f7449a82
Refines the Navigation Overlay template description to remove the "full-screen" assumption and clarify that the overlay can be toggled open and closed. Follow-up to [61609]. Props get_dave, scruffian, wildworks. See #64589. git-svn-id: https://develop.svn.wordpress.org/trunk@61734 602fd350-edb4-49c9-b593-d223f7449a82
This was previosly listed as defaulting to `false` when in fact it defaults to `true.` Developed in: #11022 Discussed in: https://core.trac.wordpress.org/ticket/64224 Reported in: WordPress/Documentation-Issue-Tracker#1849 Props dmsnell, noruzzaman, vHeemstra, westonruter. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61735 602fd350-edb4-49c9-b593-d223f7449a82
The admin reskin changed info notices to a transparent background, matching usage in Gutenberg. But with the gray background in the core admin, these notices didn't show up in an expected manner. Additionally, using a transparent background in a context where the background color is variable is risky for color contrast. Change `.notice-info`, `.notice-info.notice-alt`, and `.login .notice, .login .message` to use white backgrounds. Reverts changes from [61731] to apply styles also to `.message` class. Props mohitbsf, audrasjb, peterwilsoncc, pbiron, fabiankaegy, noruzzaman, joedolson. Fixes #64678. See #64715. git-svn-id: https://develop.svn.wordpress.org/trunk@61737 602fd350-edb4-49c9-b593-d223f7449a82
The `aria-label` on post titles in list tables changes the accessible name from `{post_title}` to `"{post_title}" (Edit)`. This change increases verbosity for screen readers and creates a mismatch between the visual text and the accessible name for voice command.
Remove the extraneous `aria-label`.
Props afercia, rianrietveld, iworks, muddassirnasim, joedolson.
Fixes #33002.
git-svn-id: https://develop.svn.wordpress.org/trunk@61738 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [61674]. Props Soean, apermo. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61739 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [61738]. Updates e2e tests to use new link name. Applies change to omitted case in term list tables. Props joedolson. Fixes #33002. git-svn-id: https://develop.svn.wordpress.org/trunk@61740 602fd350-edb4-49c9-b593-d223f7449a82
Plugin and theme installer buttons load a dashicon during their updating and updated states. These dashicons were sized to large buttons, and caused a shift in alignment after the switch to compact buttons. Update CSS to prevent shifts in size and alignment for installer buttons. Props mohitbsf, peterwilsoncc, adnanhyder, huzaifaalmesbah, noruzzaman, ravichudasama01, shailu25, r1k0, joedolson. Fixes #64687. git-svn-id: https://develop.svn.wordpress.org/trunk@61741 602fd350-edb4-49c9-b593-d223f7449a82
Fix the height, background, and positioning of the skip to editor link in the classic editor, to prevent overflow and override transparent background. Props sabernhardt, huzaifaalmesbah, joedolson. Fixes #64727. git-svn-id: https://develop.svn.wordpress.org/trunk@61742 602fd350-edb4-49c9-b593-d223f7449a82
Prevent the Twenty Twenty theme styles from overriding the Pullquote block's letter case settings. Props paragjethva, hiteshtalpada, shailu25, poena, mukesh27, sukhendu2002, dhruvang21, ugyensupport, darshitrajyaguru97, sabernhardt, r1k0, joedolson. Fixes #62773. git-svn-id: https://develop.svn.wordpress.org/trunk@61743 602fd350-edb4-49c9-b593-d223f7449a82
Adjust the line-height of the dashicon for the media panel mobile menu. Props huzaifaalmesbah, joedolson. Fixes #64726. git-svn-id: https://develop.svn.wordpress.org/trunk@61744 602fd350-edb4-49c9-b593-d223f7449a82
Remove the title attribute from `the_author_posts_link()` and related functions, retaining text for use in `the_author_posts_link` filter, and add parameter to disable title attributes in `the_author_link()`. Default behavior will still differentiate the two links, but adds the option to remove all title attributes. Props sabernhardt, alh0319, adnanlimdi, audrasjb, joedolson. Fixes #62835. See #26559. git-svn-id: https://develop.svn.wordpress.org/trunk@61745 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )