Conversation
We fix a few flaky tests in our channel FSM that test scenarios where errors are received while creating funding transactions. The issue was that we used a dummy wallet that could complete its call before our calls to `awaitCond(alice.stateName == WAIT_FOR_FUNDING_INTERNAL)`. We use a new dummy on-chain wallet that never responds to transaction funding calls to allow tests to inject failure events.
Member
|
LGTM but could we also fix the flaky tests by waiting until channels transitions to WAIT_FOR_FUNDING_SIGNED instead of WAIT_FOR_FUNDING_INTERNAL ? |
Member
Author
That wouldn't test the same FSM state, we explicitly want to test what happens while events fire before we've successfully funded the transaction. We have tests for the later states already in separate files. |
sstone
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fix a few flaky tests in our channel FSM that test scenarios where errors are received while creating funding transactions. The issue was that we used a dummy wallet that could complete its call before our calls to
awaitCond(alice.stateName == WAIT_FOR_FUNDING_INTERNAL).We use a new dummy on-chain wallet that never responds to transaction funding calls to allow tests to inject failure events.