Merged
Conversation
Those tests started randomly failing after moving to anchor outputs. The reason is that anchor outputs have a bigger commit weight than non anchor channels, and with our initial balance allocation we sometimes reached a point where the *remote* had exhausted all of its balance to pay commit fees (when the feerate was around 10 000 sat/kw), so the *local* couldn't send HTLCs (`RemoteCannotAffordFeesForNewHtlc`). This is an expected situation where we cannot do anything except wait for pending HTLCs to resolve before sending other HTLCs. We simply increase the initial balance to avoid running into this case. We also remove the `skip` case (which wasn't working at all, we should have used the `cancel` scalatest helper if we wanted to interrupt the test without failing it) and allow failures during the initial HTLC setup (which can happen if HTLCs are larger than the available balance).
pm47
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those tests started randomly failing after moving to anchor outputs. The reason is that anchor outputs have a bigger commit weight than non anchor channels, and with our initial balance allocation we sometimes reached a point where the remote had exhausted all of its balance to pay commit fees (when the feerate was around 10 000 sat/kw), so the local couldn't send HTLCs (
RemoteCannotAffordFeesForNewHtlc). This is an expected situation where we cannot do anything except wait for pending HTLCs to resolve before sending other HTLCs.We simply increase the initial balance to avoid running into this case. We also remove the
skipcase (which wasn't working at all, we should have used thecancelscalatest helper if we wanted to interrupt the test without failing it) and allow failures during the initial HTLC setup (which can happen if HTLCs are larger than the available balance).