-
Notifications
You must be signed in to change notification settings - Fork 0
Review Land Variables Mapping for CMIP7 #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rbeucher
wants to merge
48
commits into
main
Choose a base branch
from
review_land_vars
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 57.55% 52.17% -5.39%
==========================================
Files 18 18
Lines 2403 2739 +336
==========================================
+ Hits 1383 1429 +46
- Misses 1020 1310 +290 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nd carbon "cLand" calculation
…ingly, add fN... mappings
…in soil layers (NEEDS proper testing!!)
…tent (nLand) in ACCESS-ESM1.6
…on in ACCESS-ESM1.6
…oducts in ACCESS-ESM1.6
…ude in ACCESS-ESM1.6
…erotrophic respiration in ACCESS-ESM1.6
… mapping for land fraction
…pdate lev parameter to use literal values in ACCESS-ESM1.6 mappings
…andardize key casing
…arguments in ACCESS-ESM1.6 mappings
…le pattern in TestFullCMORIntegration
…le list in _filter_variables_by_test_data
ec6dbef to
e111796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new features to the land and vegetation fraction calculations in the
access_moppyderivations module. The changes enhance support for CMIP compliance by converting outputs to percentages, add new generalized mass pool calculations, and improve documentation and usability for vegetation-type handling. The most important changes are grouped below:Land and vegetation fraction calculations:
extract_tilefracfunction now outputs tile fractions as percentages (0-100%), supports an optional vegetation type dimension for CMOR character-type variables, and provides improved documentation, error handling, and vegetation type mapping. [1] [2]calc_landcoverfunction has been updated to output land cover fractions as percentages and to include descriptive vegetation type labels for both CABLE and CMIP6 models, with expanded documentation and examples. [1] [2]Generalized mass pool calculations:
calc_mass_pool_kg_m2,calc_carbon_pool_kg_m2, andcalc_nitrogen_pool_kg_m2for generalized calculation of mass pools (carbon, nitrogen, etc.) with tile weighting, spatial integration, and unit conversion to kg m-2. [1] [2] [3]calc_cland_with_wood_productsfor calculating total land carbon including wood products with proper weighting and conversion. [1] [2] [3]API and naming changes:
average_tilein favor of the newweighted_tile_sumfunction, which provides clearer semantics for tile-weighted calculations. [1] [2] [3]