Review Mapping, add support for seaice variables #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…action) for Amon.clw (total cloud liquid fraction)
…) for Amon.cli (total cloud ice fraction)
…lwvi (total column liquid + ice)
…heet suggests using fld_s30i207: GEOPOTENTIAL HEIGHT ON P LEV/UV GRID, however CMIP7 requests this on model levels and so I've instead added fld_s16i201: GEOPOTENTIAL HEIGHT ON THETA LEVELS.
…lux of carbon dioxide "ra"
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 57.55% 57.11% -0.44%
==========================================
Files 18 20 +2
Lines 2403 2458 +55
==========================================
+ Hits 1383 1404 +21
- Misses 1020 1054 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rhaegar325, I was reviewing the mapping and ended up diving into the sea ice variables, and then started looking at a few ocean variables as well.
It turned into a bit of a messy PR, sorry about that.