mods added #5
Open
mods added #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sir-Batman
requested changes
Jan 23, 2019
Member
Sir-Batman
left a comment
Sir-Batman
left a comment
There was a problem hiding this comment.
Major Comments:
- Needs proper doc strings for the newly introduced functions.
- Makefiles are not necessary in my build environment, we can either accept them as is or review your build setup to not need the makefiles.
gym_example.py
Outdated
| import code.agent_domain_2 as domain | ||
| import mods | ||
|
|
||
| #from renderer import* |
Member
There was a problem hiding this comment.
Suggested change
| #from renderer import* |
mods.py
Outdated
| (sim.data["Specifics Name"], sim.data["Mod Name"], dateTimeString) | ||
| (sim.data["Specifics Name"], sim.data["Mod Name"], dateTimeString) | ||
|
|
||
| ############################## |
Member
There was a problem hiding this comment.
Make the comment be a proper docstring (see here . Use the ReST style.
| #population to use and must also be set | ||
| ############################## | ||
|
|
||
| def assignHomogeneousPolicy(sim): |
| # | ||
| #call function after each sim.step | ||
| ############################## | ||
| def poiVelocity(sim): |
| ############################## | ||
|
|
||
|
|
||
| def abilityVariation(sim): |
| # | ||
| #call function after sim is created and after each sim.reset | ||
| ############################## | ||
| def sequentialPoi(sim): |
| #call function after sim is created | ||
| ############################## | ||
|
|
||
| def lowVisibility(sim): |
| sim.data["Observation Function"]=doAgentSenseMod | ||
|
|
||
|
|
||
| def simpleReward(data): |
| # | ||
| #call function after sim is created and before each sim.reset | ||
| ############################## | ||
| def recipePoi(sim): |
gym_example.py
Outdated
| stepCount += 1 | ||
| if ( episodeIndex%50==49 and worldIndex==0): | ||
| sim.render() | ||
| #render(sim.data) |
Member
There was a problem hiding this comment.
Suggested change
| #render(sim.data) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.