Skip to content

fix serve.bat and command example in README #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drumath2237 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

fix serve.bat and command example in README #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions serve/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ If you don't already have Node.js and npm installed, get it here: https://www.np

Example:
```
./serve/bin/serve -n -d gettingstarted/xraframe/ -p 7777
./serve/bin/serve -n -d gettingstarted/aframe/ -p 7777
```

**IMPORTANT**: To connect to this local webserver, make sure to copy the **entire** "Listening" URL into your browser, including both the "**https://**" at the beginning and **port** number at the end.
Expand All @@ -28,7 +28,7 @@ Example:

Example - specify network interface:
```
./serve/bin/serve -d gettingstarted/xraframe/ -p 7777 -i en0
./serve/bin/serve -d gettingstarted/aframe/ -p 7777 -i en0
```

## Serving locally From Windows
Expand All @@ -48,13 +48,13 @@ If you don't already have Node.js and npm installed, get it here: https://www.np

Example:
```
serve\bin\serve.bat -n -d gettingstarted\xraframe -p 7777
serve\bin\serve.bat -n -d gettingstarted\aframe -p 7777
```
**IMPORTANT**: To connect to this local webserver, make sure to copy the **entire** "Listening" URL into your browser, including both the "**https://**" at the beginning and **port** number at the end.

**NOTE**: If the serve script states it's listening on **127.0.0.1**:<port\> (which is the loopback device aka "localhost") your mobile phone won't be able to connect to that IP address directly. Please re-run the `serve` script with the `-i` flag to specify the network interface the serve script should listen on.

Example - specify network interface:
```
serve\bin\serve.bat -d gettingstarted\xraframe -p 7777 -i WiFi
serve\bin\serve.bat -d gettingstarted\aframe -p 7777 -i WiFi
```
2 changes: 1 addition & 1 deletion serve/bin/serve.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ IF %PRINT_INSTRUCTIONS% == true (
)

cd %DIRNAME%
node src\index.js %SERVE%
node serve\src\index.js %SERVE%

EXIT /B %ERRORLEVEL%

Expand Down