Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

CLA assistant #1187

Merged
matextrem merged 13 commits into from
Aug 4, 2020
Merged

CLA assistant #1187

matextrem merged 13 commits into from
Aug 4, 2020

Conversation

@matextrem
Copy link
Contributor

@matextrem matextrem commented Jul 30, 2020 •
edited
Loading

closes #1133

Depends on #1188

@matextrem matextrem added the Dev Tooling 🛠️ Developer tooling label Jul 30, 2020
@matextrem matextrem added this to the Sprint 9 milestone Jul 30, 2020
@matextrem matextrem requested review from fernandomg and mmv08 July 30, 2020 23:37
@matextrem matextrem self-assigned this Jul 30, 2020
@github-actions
Copy link

github-actions bot commented Jul 30, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jul 30, 2020

Travis automatic deployment:
https://pr1187--safereact.review.gnosisdev.com/app

@matextrem matextrem mentioned this pull request Jul 31, 2020
Merged
@ghost
Copy link

ghost commented Jul 31, 2020

Travis automatic deployment:
https://pr1187--safereact.review.gnosisdev.com/app

mmv08
mmv08 reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@mmv08 mmv08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we maybe create a repo where we test this first?

@ghost
Copy link

ghost commented Jul 31, 2020

Travis automatic deployment:
https://pr1187--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Jul 31, 2020

Travis automatic deployment:
https://pr1187--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Jul 31, 2020

Travis automatic deployment:
https://pr1187--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Jul 31, 2020

Travis automatic deployment:
https://pr1187--safereact.review.gnosisdev.com/app

@matextrem
Copy link
Contributor Author

matextrem commented Jul 31, 2020

should we maybe create a repo where we test this first?

I did it matextrem/safe-electron-multisig#4 and it seems to be working fine.

@mmv08
Copy link
Contributor

mmv08 commented Jul 31, 2020 •
edited
Loading

Cool, it fails here though. Could you please take a look?

@ghost
Copy link

ghost commented Aug 4, 2020

Travis automatic deployment:
https://pr1187--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Aug 4, 2020

Travis automatic deployment:
https://pr1187--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Aug 4, 2020

Travis automatic deployment:
https://pr1187--safereact.review.gnosisdev.com/app

@github-actions
Copy link

github-actions bot commented Aug 4, 2020 •
edited
Loading

CLA Assistant Lite All Contributors have signed the CLA.

@ghost
Copy link

ghost commented Aug 4, 2020

Travis automatic deployment:
https://pr1187--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Aug 4, 2020

Travis automatic deployment:
https://pr1187--safereact.review.gnosisdev.com/app

@mmv08
Copy link
Contributor

mmv08 commented Aug 4, 2020

@matextrem could you please link your email used for first two commits to your github account?

@matextrem
Copy link
Contributor Author

matextrem commented Aug 4, 2020

Done!

@mmv08
Copy link
Contributor

mmv08 commented Aug 4, 2020

recheckcla

@mmv08
Copy link
Contributor

mmv08 commented Aug 4, 2020

doesn't seem to work 🤔

@mmv08
Copy link
Contributor

mmv08 commented Aug 4, 2020

recheckcla

@matextrem
Copy link
Contributor Author

matextrem commented Aug 4, 2020

It passed successfully now

@mmv08
Copy link
Contributor

mmv08 commented Aug 4, 2020

yes, because I re-ran it. Have you tested actual CLA signing functionality?

@matextrem
Copy link
Contributor Author

matextrem commented Aug 4, 2020

No. I've tested it recently in my repo and it does not work either.

@mmv08
Copy link
Contributor

mmv08 commented Aug 4, 2020

are you going to debug/research the problem or you need help?

@matextrem
Copy link
Contributor Author

matextrem commented Aug 4, 2020

I'm going to investigate it and let you know

mmv08
mmv08 approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@mmv08 mmv08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mati shared this with me:

https://stackoverflow.com/questions/59778589/github-action-receive-event-when-comment-added-to-pr

The workflow must be committed to the master branch for issue_comment events to trigger. See the documentation where it says the GITHUB_SHA for the event is the "last commit on default branch." –

@matextrem matextrem merged commit 4130902 into development Aug 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2020
@mmv08 mmv08 deleted the feature/cla-assistant branch August 4, 2020 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fernandomg fernandomg Awaiting requested review from fernandomg

1 more reviewer

@mmv08 mmv08 mmv08 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@matextrem matextrem

Labels

Dev Tooling 🛠️ Developer tooling

Projects

None yet

Milestone

Sprint 9

Development

Successfully merging this pull request may close these issues.

CLA Assistant

3 participants

@matextrem @mmv08