Skip to content

[Snyk] Upgrade react-dom from 19.2.0 to 19.2.1 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
512Andrew wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Upgrade react-dom from 19.2.0 to 19.2.1 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@react-three/fiber": "^9.4.0",
"next": "^16.0.10",
"react": "19.2.0",
Copy link

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading react-dom to 19.2.1 while keeping react at 19.2.0 creates a version mismatch. According to the package-lock.json changes, react-dom 19.2.1 has a peer dependency of "^19.2.1" for react, but the current react version is pinned at 19.2.0. This mismatch will likely cause a peer dependency warning or error during installation. Both react and react-dom should be upgraded together to 19.2.1 to maintain compatibility.

Suggested change
"react": "19.2.0",
"react": "19.2.1",

Copilot uses AI. Check for mistakes.
"react-dom": "19.2.0",
"react-dom": "19.2.1",
Copy link

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version format is inconsistent with the package-lock.json. In package.json line 18, react-dom should use the caret prefix (^19.2.1) to match the format used in package-lock.json line 15. Without the caret, the package will be pinned to exactly 19.2.1, while package-lock.json indicates a range starting from ^19.2.1. This inconsistency can cause confusion and unexpected behavior during dependency resolution.

Suggested change
"react-dom": "19.2.1",
"react-dom": "^19.2.1",

Copilot uses AI. Check for mistakes.
"three": "^0.181.2"
},
"devDependencies": {
Expand Down