Conversation
taion
left a comment
taion
left a comment
There was a problem hiding this comment.
i mostly just skimmed 5451a28...feat/example#diff-75c62265150520cb1789948a67223782R20
it looks like you re-synced the schema to https://github.com/relayjs/relay-examples/blob/master/todo/data/schema/index.js , and otherwise the react code is different in the new subscription logic + the use of relay-network-layer?
| @@ -0,0 +1,5 @@ | |||
| node_modules | |||
There was a problem hiding this comment.
could maybe use the same one as in base. or even just have the base package handle linting here
| @@ -0,0 +1,4 @@ | |||
| .DS_Store | |||
There was a problem hiding this comment.
maybe not needed? shouldn't the base gitignore already handle this stuff?
|
|
||
| useEffect(() => { | ||
| // initialize subscriptions | ||
| const removeDisposable = removeTodoSubscription(); |
There was a problem hiding this comment.
might be better to name this as requestRemoveTodoSubscription, &c.
|
Really just copy/pasted the relay todo example, diffed and copied our flow version, then just got it to work with relay-network-layer. So basically what you said 😆 |
|
I SEE YOU ETHAN |
|
Why didn't we just merge this again? |
|
I don't know 👋 hey Jimmy |
|
tbh i didn't realize this was here I would have used it in #407 where I added half of this |
3 participants
No description provided.