Skip to content

Comments

Hide Password Generator from Create Seed menu flow#300

Merged
3rdIteration merged 1 commit intodevfrom
codex/remove-password-generator-from-create-seed-menu
Feb 19, 2026
Merged

Hide Password Generator from Create Seed menu flow#300
3rdIteration merged 1 commit intodevfrom
codex/remove-password-generator-from-create-seed-menu

Conversation

@3rdIteration
Copy link
Owner

Motivation

  • The Password Generator option was visible when entering the "Create a seed" flow, but it should only be available from the Tools entry point.

Description

  • Add an include_password_generator toggle to ToolsMenuView (default True) and only append the PASSWORD_GENERATOR button when the toggle is set.
  • Preserve backward compatibility by using getattr(self, "include_password_generator", True) to handle older instantiations that don't pass the flag.
  • Update create-seed entry points to open ToolsMenuView with view_args={"include_password_generator": False} from LoadSeedView and the Satochip import create flow so Password Generator is hidden in that context.
  • Add tests (tests/test_create_seed_menu.py) validating the route/view_args and that the Password Generator button is omitted when disabled.

Testing

  • Ran pytest -q tests/test_create_seed_menu.py tests/test_password_generator_views.py::test_tools_menu_back_returns_back_stack and all tests passed.
  • Test run result: 3 passed.

Codex Task

Copilot AI review requested due to automatic review settings February 19, 2026 02:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a UX issue where the Password Generator option was incorrectly appearing in the "Create a seed" menu flow, when it should only be accessible from the main Tools entry point.

Changes:

  • Added an optional include_password_generator parameter to ToolsMenuView (defaults to True for backward compatibility)
  • Updated two seed creation entry points (LoadSeedView and ToolsSatochipImportSeedView) to pass include_password_generator=False when navigating to ToolsMenuView
  • Added comprehensive test coverage validating the new behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/seedsigner/views/tools_views.py Added include_password_generator parameter to ToolsMenuView.__init__() and conditional logic in run() method; updated ToolsSatochipImportSeedView to pass the parameter when creating seeds
src/seedsigner/views/seed_views.py Updated LoadSeedView to pass include_password_generator=False when routing to ToolsMenuView for seed creation
tests/test_create_seed_menu.py New test file with two tests: one verifying the routing with correct view_args, another verifying Password Generator is excluded from the button list when disabled

@3rdIteration 3rdIteration merged commit d06ea5a into dev Feb 19, 2026
15 checks passed
@3rdIteration 3rdIteration deleted the codex/remove-password-generator-from-create-seed-menu branch February 19, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant