Hide Password Generator from Create Seed menu flow#300
Merged
3rdIteration merged 1 commit intodevfrom Feb 19, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a UX issue where the Password Generator option was incorrectly appearing in the "Create a seed" menu flow, when it should only be accessible from the main Tools entry point.
Changes:
- Added an optional
include_password_generatorparameter toToolsMenuView(defaults toTruefor backward compatibility) - Updated two seed creation entry points (
LoadSeedViewandToolsSatochipImportSeedView) to passinclude_password_generator=Falsewhen navigating toToolsMenuView - Added comprehensive test coverage validating the new behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/seedsigner/views/tools_views.py |
Added include_password_generator parameter to ToolsMenuView.__init__() and conditional logic in run() method; updated ToolsSatochipImportSeedView to pass the parameter when creating seeds |
src/seedsigner/views/seed_views.py |
Updated LoadSeedView to pass include_password_generator=False when routing to ToolsMenuView for seed creation |
tests/test_create_seed_menu.py |
New test file with two tests: one verifying the routing with correct view_args, another verifying Password Generator is excluded from the button list when disabled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
include_password_generatortoggle toToolsMenuView(defaultTrue) and only append thePASSWORD_GENERATORbutton when the toggle is set.getattr(self, "include_password_generator", True)to handle older instantiations that don't pass the flag.ToolsMenuViewwithview_args={"include_password_generator": False}fromLoadSeedViewand the Satochip import create flow so Password Generator is hidden in that context.tests/test_create_seed_menu.py) validating the route/view_args and that the Password Generator button is omitted when disabled.Testing
pytest -q tests/test_create_seed_menu.py tests/test_password_generator_views.py::test_tools_menu_back_returns_back_stackand all tests passed.3 passed.Codex Task