Skip to content

Conversation

@chemiskyy
Copy link
Member

Add a functional example to remesh a gyroid based on CAD to avoid poor mesh quality on periodic faces

Capture d’écran 2025-03-25 à 14 14 47

@kmarchais
Copy link
Member

Very nice mesh, I think we should start using docstring in the beginning of the example files to describe what it does. And for this one to warn that it can be long to run.

Also since, it is saving a step file to be able to mesh it, maybe we should use temporary files?
If too complex for the example, maybe mesh and meshPeriodic could take a cadquery object as input (and then export as a temp file in a specific function)

@chemiskyy chemiskyy requested a review from Copilot March 28, 2025 12:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new functional example to remesh a gyroid based on CAD data to improve mesh quality on periodic faces.

  • Updated exclusion list in the run_examples script to include the new "Mesh/gyroid" directory.
  • Added a new example script (gyroid_step_remesh.py) that demonstrates a complete remeshing workflow using CAD export and periodic meshing tools.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
examples/run_examples.py Extended exclusion list to account for the new gyroid remeshing example
examples/Mesh/gyroid/gyroid_step_remesh.py Introduces a complete example for gyroid remeshing via CAD processing
Comments suppressed due to low confidence (1)

examples/Mesh/gyroid/gyroid_step_remesh.py:14

  • [nitpick] Consider renaming 'listPhases' to 'phases' to better align with Python's snake_case naming conventions.
listPhases = []

Copy link
Member

@kmarchais kmarchais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@chemiskyy chemiskyy merged commit ae275ed into main Oct 6, 2025
26 checks passed
@chemiskyy chemiskyy deleted the add_example_remesh branch October 6, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants