Skip to content

Conversation

@ylgrst
Copy link
Collaborator

@ylgrst ylgrst commented Apr 30, 2025

This PR changes remesh.py:

  • The remesher now works in case the user wants to remesh while keeping the boundary elements untouched, regardless of periodicity

  • remesh_keeping_periodicity_for_fem has been renamed to remesh_keeping_boundaries_for_fem. To ensure backwards compatibility, remesh_keeping_periodicity_for_fem can still be called but raises a deprecation warning

  • A new parameter has been added to remesh_keeping_boundaries_for_fem: if periodic=True (default), the remesher will check for periodicity before and after the operation (ie: the previous remesh_keeping_periodicity_for_fem behavior)

The relevant test has been added to test_remesh.py

Copy link
Collaborator

@ricardo0115 ricardo0115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small precision about what should we do when MMG is set to False.

Also is very important to note the change of this method name because it could lead to breaking retro incompatibilities issues in future Microgen releases.

@ricardo0115 ricardo0115 merged commit 15f1f9d into main May 1, 2025
13 checks passed
@ricardo0115 ricardo0115 deleted the bugfix/remesh branch May 1, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants