Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
remesh.py:The remesher now works in case the user wants to remesh while keeping the boundary elements untouched, regardless of periodicity
remesh_keeping_periodicity_for_femhas been renamed toremesh_keeping_boundaries_for_fem. To ensure backwards compatibility,remesh_keeping_periodicity_for_femcan still be called but raises a deprecation warningA new parameter has been added to remesh_keeping_boundaries_for_fem: if
periodic=True(default), the remesher will check for periodicity before and after the operation (ie: the previousremesh_keeping_periodicity_for_fembehavior)The relevant test has been added to
test_remesh.py