[makerom] Add support for New3DS bit in Title ID #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroSkill1
changed the title
Collaborator
|
Thank you for the PR, this is certainly missing from makerom functionality. I did some investigation, and New3DS exclusive games don't set this value in the program ID. I've only seen it in system titles that need to be distinct from the Old3DS versions. So given it's clearly optional for New3DS titles to use it, a flag makes sense. I'll merge this in a bit. |
Author
|
Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makerom is currently missing the functionality to add the New3DS-only bit to title IDs. This makes it impossible to use makerom for creating New3DS-only variations of certain system titles, e.g.:
mcu uses title ID
0004013000001F02.but the New3DS specific variation of it uses
0004013020001F02.I have added this functionality through the use of a new Option field
UseKtrProgramIdin the RSF. I'm open to renaming the field or using an alternative method to specify this option, though I thought adding it to the RSF would be the most fitting in this case.