Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR configures a custom Reposilite Maven repository for the project by adding distribution management and repository definitions to both the root POM and all module POMs.
- Adds Reposilite repository configuration for both releases and snapshots
- Propagates the same repository settings to all Maven modules in the project
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Adds root-level Reposilite distribution management and repository configuration |
| phoenixd-test/pom.xml | Duplicates Reposilite configuration in test module |
| phoenixd-rest/pom.xml | Duplicates Reposilite configuration in REST module |
| phoenixd-model/pom.xml | Duplicates Reposilite configuration in model module |
| phoenixd-base/pom.xml | Duplicates Reposilite configuration in base module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <id>reposilite-releases</id> | ||
| <url>https://maven.398ja.xyz/releases</url> | ||
| </repository> | ||
| </repositories> |
There was a problem hiding this comment.
The distributionManagement and repositories sections are duplicated across all module POMs. Since these modules inherit from the root POM, this configuration should be inherited automatically and doesn't need to be redefined in each module.
| </repositories> |
| <id>reposilite-releases</id> | ||
| <url>https://maven.398ja.xyz/releases</url> | ||
| </repository> | ||
| </repositories> |
There was a problem hiding this comment.
The distributionManagement and repositories sections are duplicated across all module POMs. Since these modules inherit from the root POM, this configuration should be inherited automatically and doesn't need to be redefined in each module.
| </repositories> |
| <id>reposilite-releases</id> | ||
| <url>https://maven.398ja.xyz/releases</url> | ||
| </repository> | ||
| </repositories> |
There was a problem hiding this comment.
The distributionManagement and repositories sections are duplicated across all module POMs. Since these modules inherit from the root POM, this configuration should be inherited automatically and doesn't need to be redefined in each module.
| </repositories> |
| <id>reposilite-releases</id> | ||
| <url>https://maven.398ja.xyz/releases</url> | ||
| </repository> | ||
| </repositories> |
There was a problem hiding this comment.
The distributionManagement and repositories sections are duplicated across all module POMs. Since these modules inherit from the root POM, this configuration should be inherited automatically and doesn't need to be redefined in each module.
| </repositories> |
Summary
Testing
mvn -q verify(fails: CreateInvoiceParamTest, PayBolt11InvoiceInvoiceResponseTest, PayLightningAddressInvoiceResponseTest)https://chatgpt.com/codex/tasks/task_b_68a64afb04a08331b2bd9fdf8020c3d9