Skip to content

main 브렌치 최신화 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
taemin3 merged 37 commits into from
Oct 17, 2025
Merged

main 브렌치 최신화 #13

taemin3 merged 37 commits into from
Oct 17, 2025

Conversation

@taemin3
Copy link
Contributor

@taemin3 taemin3 commented Oct 17, 2025

📝 Summary

main 브렌치 최신화

🙏 Question & PR point

📬 Reference

Kim Taemin and others added 30 commits October 12, 2025 18:30
[FEAT] 자재 관련 엔티티 구현
6fbdaef
[FEAT] 공장 자재 관련 api 구현
387f900
@taemin3
Merge pull request #2 from 33-Auto/feat/#1
f8200c5 
Feat/#1 공장 자재 관련 기본 api 구현
@CHOOSLA
Merge pull request #6 from 33-Auto/main
69340d0 
Dev브랜치를 업데이트합니다
@CHOOSLA
chore: Apply batch updates from central configuration
4147fa3
[FIX] 공장 서비스 api 경로 변경
1d6e0b2
@taemin3
Merge pull request #7 from 33-Auto/SPM-74
d37c026 
[FIX] 공장 서비스 api 경로 변경
[FIX] 스웨거 설정 수정
d78c46b
@taemin3
Merge pull request #8 from 33-Auto/SPM-87
8f4553e 
[FIX] 스웨거 설정 수정
[FIX] 자재, 자재 카테고리 엔티티 읽기 전용으로 수정
ee38ef3
@taemin3
Merge pull request #9 from 33-Auto/SPM-89
3295cc2 
[FIX] 자재, 자재 카테고리 엔티티 읽기 전용으로 수정
[FEAT] 공장 생성 api 구현
d53fc1a
[FEAT] 공장 생성 시 입력 검증
15edb2e
@taemin3
Merge pull request #10 from 33-Auto/SPM-91
9344d3c 
[FEAT] 공장 생성 api 구현
[FIX] 공장 자재 관련 엔티티 수정
3961874
@CHOOSLA
chore: Apply batch updates from central configuration
8643ae8
[FEAT] 부품 관련 api 구현
d5dcfdb
[FIX] 공장 및 자재 관련 엔티티 수정
3aacd6f
[FEAT] BOM 관련 api 구현
f8443cd
@CHOOSLA
chore: Apply batch updates from central configuration
9a6d584
@CHOOSLA
chore: Apply batch updates from central configuration
481233b
@CHOOSLA
chore: Apply batch updates from central configuration
fe1462d
@CHOOSLA
chore: Apply batch updates from central configuration
fa3cb69
@CHOOSLA
chore: Apply batch updates from central configuration
6ed3f84
@CHOOSLA
chore: Apply batch updates from central configuration
5eab7da
@CHOOSLA
chore: Apply batch updates from central configuration
ea12978
@CHOOSLA
chore: Apply batch updates from central configuration
c17461d
[FIX] bom 엔티티 수정
90d916b
@taemin3
Merge pull request #11 from 33-Auto/SPM-36
f510f01 
Spm 36 BOM 관련 api 구현
[FEAT] 자재 목록/검색 api 구현 및 자재 주문 삭제, 취소 api 구현
b37ec3b
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 17, 2025
View reviewed changes
.github/workflows/pr-reminder.yml
Comment on lines +10 to +15
uses: 33-Auto/.github/.github/workflows/reusable-pr-reminder.yml@main
secrets:
# 해당 시크릿은 조직의 시크릿에 저장되어 있음
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
with:
SLACK_USER_MAP: ${{ vars.SLACK_USER_MAP }} No newline at end of file

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 4 months ago

To fix the problem:

  • Explicitly add a permissions block either at the workflow root level, which applies to all jobs unless they override it, or to the specific job if requirements differ by job.
  • The root-level block is most effective for this workflow, since only a single job exists and there is no indication that more jobs will be added.
  • Set the permissions to the minimum level needed. For most scheduled notification workflows, contents: read is sufficient unless pull request or issues write access is demonstrably required. If, in inspection, we find that SLACK integration is handled outside the repository, contents: read will suffice.
  • Edit .github/workflows/pr-reminder.yml by adding: 
    permissions:
  contents: read
    just after the name declaration and before the on block.
Suggested changeset 1
.github/workflows/pr-reminder.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/pr-reminder.yml b/.github/workflows/pr-reminder.yml
--- a/.github/workflows/pr-reminder.yml
+++ b/.github/workflows/pr-reminder.yml
@@ -1,4 +1,6 @@
   name: PR Reminder
+  permissions:
+    contents: read
 
   on:
     schedule:
EOF
@@ -1,4 +1,6 @@
name: PR Reminder
permissions:
contents: read

on:
schedule:
Copilot is powered by AI and may make mistakes. Always verify output.
@coderabbitai
Copy link

coderabbitai bot commented Oct 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

Comment @coderabbitai help to get the list of available commands and usage tips.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 17, 2025
View reviewed changes
.github/workflows/trigger_infra.yml
Comment on lines 10 to 20
runs-on: ubuntu-latest
steps:
- name: Trigger infra repo deploy workflow
uses: peter-evans/repository-dispatch@v3
with:
token: ${{ secrets.ORGANIZATION_TOKEN }}
# [중요] 아래 repository 값은 모든 앱이 공유하는 '중앙 인프라 리포지토리' 주소이다.
repository: 33-Auto/Sampoom-Management-Backend-Infra
event-type: deploy
# 'Sampoom-Management-Backend-Part'은 스크립트가 동적으로 치환할 자리표시자(placeholder)이다.
client-payload: '{"service":"Sampoom-Management-Backend-Part","branch":"main"}' No newline at end of file

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 4 months ago

To fix the problem, explicitly set the permissions: key for the workflow. Since the only built-in action is one that uses a repository dispatch (via a user-provided token), the job does not actually require any permissions granted to the default GITHUB_TOKEN. Therefore, we can safely set the permissions to none at the workflow or job level, following the principle of least privilege. The best and most future-proof way is to add permissions: {} at the workflow root level, so all jobs inherit the most restrictive permissions unless they specifically need more.

How to fix:

  • Add permissions: {} (equivalent to no permissions for GITHUB_TOKEN) at the root of the workflow, preferably after the name field and before on: for clarity.
  • No other code changes or dependency additions required.
Suggested changeset 1
.github/workflows/trigger_infra.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/trigger_infra.yml b/.github/workflows/trigger_infra.yml
--- a/.github/workflows/trigger_infra.yml
+++ b/.github/workflows/trigger_infra.yml
@@ -1,4 +1,5 @@
 name: Trigger Infra CD
+permissions: {}
 
 on:
   push:
EOF
@@ -1,4 +1,5 @@
name: Trigger Infra CD
permissions: {}

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
CHOOSLA
CHOOSLA approved these changes Oct 17, 2025
View reviewed changes
Copy link
Member

@CHOOSLA CHOOSLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승인

vivivim
vivivim approved these changes Oct 17, 2025
View reviewed changes
Copy link

@vivivim vivivim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최신화하십시요

Sangyoon98
Sangyoon98 approved these changes Oct 17, 2025
View reviewed changes
Copy link
Member

@Sangyoon98 Sangyoon98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승인

@33Auto-Bot 33Auto-Bot added the ready-to-merge 3명 이상의 리뷰어에게 승인되어 병합 준비가 완료된 PR label Oct 17, 2025
@taemin3 taemin3 merged commit 04403d8 into main Oct 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sangyoon98 Sangyoon98 Sangyoon98 approved these changes

@CHOOSLA CHOOSLA CHOOSLA approved these changes

@vivivim vivivim vivivim approved these changes

@yangjiseonn yangjiseonn Awaiting requested review from yangjiseonn

@Lee-Jong-Jin Lee-Jong-Jin Awaiting requested review from Lee-Jong-Jin

Assignees

No one assigned

Labels

ready-to-merge 3명 이상의 리뷰어에게 승인되어 병합 준비가 완료된 PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@taemin3 @Sangyoon98 @CHOOSLA @vivivim @33Auto-Bot