-
Notifications
You must be signed in to change notification settings - Fork 1
Main 코드 업데이트 #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main 코드 업데이트 #29
Conversation
[SPM-329] 주문 로직 수정, 예외 처리 전역 스낵바 적용, 패키지 구조 리팩토링
[FIX] 로그인, 회원가입 로직 수정 / 설정 화면 구성
[REFAC] 직급 Enum 변경
[FEAT] 부품 가격 추가
[FEAT] 대시보드 api 연동
| uses: 33-Auto/.github/.github/workflows/reusable-assign-issue-creator.yml@main | ||
| # 이 워크플로우는 secrets를 전달할 필요가 없지만, 필요 시 아래와 같이 전달합니다. | ||
| # secrets: inherit No newline at end of file |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To fix the problem, add an explicit permissions key to the job or workflow. Since this workflow delegates all responsibility to a reusable workflow, and there are no steps defined here that would require write access, it is safest to set the permissions to read-all for this job. This can be achieved by adding either permissions: read-all at the job level (call-reusable-workflow:) or at the root of the workflow. Since there is only one job, setting it at the job level is clear and follows best practice.
Add the following block:
permissions: read-allunder the call-reusable-workflow: job (that is, on line 12 or 13, properly indented).
No imports, method definitions, or other structural changes are required—just a single YAML key.
-
Copy modified line R11
| @@ -8,6 +8,7 @@ | ||
|
|
||
| jobs: | ||
| call-reusable-workflow: | ||
| permissions: read-all | ||
| # @main 은 .github 레포지토리의 main 브랜치를 사용한다는 의미입니다. 버전을 위해 @v1과 같이 태그를 사용하는 것을 권장합니다. | ||
| uses: 33-Auto/.github/.github/workflows/reusable-assign-issue-creator.yml@main | ||
| # 이 워크플로우는 secrets를 전달할 필요가 없지만, 필요 시 아래와 같이 전달합니다. |
| if: > | ||
| github.event.pull_request.merged == true && | ||
| github.event.pull_request.base.ref == 'dev' | ||
| uses: 33-Auto/.github/.github/workflows/reusable-close-linked-issues.yml@main | ||
| # with를 통해 재사용 워크플로우의 inputs에 값을 전달합니다. | ||
| with: | ||
| pr-body: ${{ github.event.pull_request.body }} | ||
| issue-number: ${{ github.event.pull_request.number }} | ||
| secrets: inherit # 재사용 워크플로우가 GITHUB_TOKEN을 사용할 수 있도록 전달 No newline at end of file |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To fix the problem, add an explicit permissions block at the root of the workflow (i.e., at the same level as name and on), so that it applies to the entire workflow and to all jobs unless overridden. The block should grant only the minimum required permissions. Since the job is closing issues (which requires the issues: write permission) and is triggered on pull request events (for which contents metadata read access may be needed), set:
permissions:
contents: read
issues: writeFor maximum safety, don't add additional permissions without clear evidence they are needed.
Place this block after the name line (line 3) and before the on line (line 5).
-
Copy modified lines R4-R6
| @@ -1,6 +1,9 @@ | ||
| # 각 레포지토리의 .github/workflows/close-issues-on-dev-merge.yml | ||
|
|
||
| name: Auto Close Issues on dev merge | ||
| permissions: | ||
| contents: read | ||
| issues: write | ||
|
|
||
| on: | ||
| pull_request: |
| uses: 33-Auto/.github/.github/workflows/reusable-pr-reminder.yml@main | ||
| secrets: | ||
| # 해당 시크릿은 조직의 시크릿에 저장되어 있음 | ||
| SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} | ||
| with: | ||
| SLACK_USER_MAP: ${{ vars.SLACK_USER_MAP }} No newline at end of file |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To fix the problem, we should add a permissions block at the workflow level or at the job level for call-reusable-reminder in .github/workflows/pr-reminder.yml. As the workflow is primarily running a reusable workflow via uses:, it's safest to set explicit minimal permissions at workflow level so all jobs inherit it. The block should specify the least privilege required; typically, for read-only workflows, this is contents: read. If the reusable workflow requires write access to, for example, pull-requests, then that should be included, but absent further information, a minimal starting block is preferred. The change consists of inserting the permissions: block just after the workflow name.
-
Copy modified lines R2-R3
| @@ -1,4 +1,6 @@ | ||
| name: PR Reminder | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| schedule: |
| uses: 33-Auto/.github/.github/workflows/reusable-pr-assign-and-review.yml@main | ||
| with: | ||
| team-slug-for-review: "review_avengers" # 여기에 리뷰를 요청할 팀의 slug를 입력합니다. | ||
| pr-author: ${{ github.event.pull_request.user.login }} | ||
| pr-number: ${{ github.event.pull_request.number }} | ||
| secrets: | ||
| ORGANIZATION_TOKEN: ${{ secrets.ORGANIZATION_TOKEN }} # 재사용 워크플로우가 ORGANIZATION_TOKEN을 사용할 수 있도록 전달 |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To fix this problem, you should add a permissions block specifying the least privilege required for this workflow. Since the workflow is calling a reusable workflow handling PR assignments and review requests, the required minimal permissions are typically contents: read (to allow basic access and context), and pull-requests: write (to interact with PRs). Insert the following block above jobs: (line 9), or at the top level of the workflow, unless specific jobs require customized permissions. No other code needs changing, only the addition of the permissions block.
-
Copy modified lines R5-R8
| @@ -2,6 +2,10 @@ | ||
|
|
||
| name: PR Assignee & Team Review Request | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, reopened, ready_for_review] |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
taemin3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다
No description provided.