Skip to content

feat: add desktop notification when agent prompts with multichoice question #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1code-async wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add desktop notification when agent prompts with multichoice question #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/renderer/features/agents/main/active-chat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2024,6 +2024,9 @@ const ChatViewInner = memo(function ChatViewInner({
(state) => state.allSubChats.find((sc) => sc.id === subChatId)?.name || "",
)

// Desktop notifications for agent events
const { notifyAgentNeedsInput } = useDesktopNotifications()

// Mutation for renaming sub-chat
const renameSubChatMutation = api.agents.renameSubChat.useMutation({
onError: (error) => {
Expand Down Expand Up @@ -2628,6 +2631,24 @@ const ChatViewInner = memo(function ChatViewInner({
}
}, [subChatId, lastAssistantMessage, isStreaming, pendingQuestions, setPendingQuestionsMap])

// Track previous pending question toolUseId to detect new questions
const prevPendingQuestionToolUseIdRef = useRef<string | null>(null)

// Notify user when a new AskUserQuestion arrives (when window is not focused)
useEffect(() => {
if (pendingQuestions) {
// Only notify if this is a NEW question (different toolUseId)
if (prevPendingQuestionToolUseIdRef.current !== pendingQuestions.toolUseId) {
prevPendingQuestionToolUseIdRef.current = pendingQuestions.toolUseId
// notifyAgentNeedsInput already checks document.hasFocus() internally
notifyAgentNeedsInput(subChatName || "Agent")
}
} else {
// Clear the ref when there's no pending question
prevPendingQuestionToolUseIdRef.current = null
}
}, [pendingQuestions, subChatName, notifyAgentNeedsInput])

// Helper to clear pending and expired questions for this subChat (used in callbacks)
const clearPendingQuestionCallback = useCallback(() => {
setPendingQuestionsMap((current) => {
Expand Down