Add distinct notification sound for agent prompts (ENG-584) #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Play a different sound when the agent asks a question (AskUserQuestion) to distinguish it from the completion notification: - Add new promptSoundNotificationsEnabledAtom preference (enabled by default) - Create notification-sounds.ts utility with Web Audio API for distinct tone - Trigger prompt sound in ipc-chat-transport when questions are received - Add "Prompt Sound" toggle in Preferences settings The prompt sound uses an ascending two-tone pattern (C5→E5) to feel like a question, while the existing completion sound remains unchanged. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
src/renderer/lib/notification-sounds.ts: New utility file withplayPromptSound()function using Web Audio APIsrc/renderer/lib/atoms/index.ts: AddpromptSoundNotificationsEnabledAtompreference (enabled by default)src/renderer/features/agents/lib/ipc-chat-transport.ts: Play prompt sound whenask-user-questionchunk is receivedsrc/renderer/components/dialogs/settings-tabs/agents-preferences-tab.tsx: Add "Prompt Sound" toggle in PreferencesTest plan
🤖 Generated with Claude Code