This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Fix swap/swapWithReferral/swapMulti return value #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return value of all three functions is always `0`.
|
Does this mean swap will never work, if it just returns zero? I am getting SafeERC20: low-level call failed error and not sure whether this is related or no. |
Author
|
It shouldn't cause any failures unless other contracts depend non a nonzero return value. |
|
Oh okay, so my problem lies somewhere else. I am not able to succesfully swap any tokens. Contract being deprecated and replaced by web API is not a problem? Can I use it anyway? |
Mewjaden
approved these changes
Jun 30, 2022
Mewjaden
approved these changes
Jul 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return value of all three functions is always
0.