Open
Conversation
197g
reviewed
Jun 13, 2023
Owner
197g
left a comment
There was a problem hiding this comment.
into_iter(self) looks quite good, sure.
That said, I'm not sure if TryFrom is the right trait here, necessarily. In that the parameter HashSet<String> is quite specific and that specificity is motivated by implementation details primarily.
On the other hand, why not special case the zero-allocation conversion.
I'd be eager to explore alternatives and hear more arguments either.
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the scope struct acces, by adding an
into_iterand a safeTryFrom<HashMap>;I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.