This repository was archived by the owner on Dec 8, 2017. It is now read-only.
Ensure 18F/hookshot is run; pass jsonOptions right #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config.payloadLimit wasn't getting passed to the hookshot constructor as it should have been, and therefore wasn't having any effect.
Contributor
Author
|
Closing this, since the running server has been superseded by the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.payloadLimitwasn't getting passed to thehookshotconstructor as it should have been, and therefore wasn't having any effect. This happened after the refactoring in #31 that generalized the creation of webhook listeners viaconfig.builders, but no longer passed thejsonOptionsobject to thehookshotconstructor.On top of that, my changes in coreh/hookshot#12 still haven't been merged, and I hadn't made sure that my custom
18F/hookshot#json-optionsbranch was installed. (See also 18F/hookshot#14 and 18F/hookshot#15.)Both issues are presently rectified in production via this change (by fetching this branch and running
npm installin the host repo). I confirmed this by resending the webhook from 18F/web-design-standards that caused the server to fail earlier this evening, and observing a successful build in the log file.cc: @arowla @afeld @maya @mollieru