This repository was archived by the owner on Dec 8, 2017. It is now read-only.
Deploy public Hub with Hookshot request size fix #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The public Hub push in #370 failed due to the webhook exceeding the default 100K limit, just as in 18F/pages#15. This applies the same fix as 18F/pages. Still waiting on coreh/hookshot#12 to get merged upstream, so I've already installed 18F/hookshot#json-options on the server: ``` npm install git+ssh://git@github.com/18F/hookshot.git#json-options ``` Note: I applied this in 18F/18f.gsa.gov#1102, but really should've just applied it here. No harm done, however.
Pass through bodyParser.json() middleware options
mbland
added a commit
that referenced
this pull request
Aug 17, 2015
Deploy public Hub with Hookshot request size fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem with hookshot choking on webhooks that are too large, per #371.
cc: @gboone