This repository was archived by the owner on May 22, 2025. It is now read-only.
Open
Conversation
Author
|
@tylercherpak @tlovett1 This may be worth including in a future release to speed up WP Snapshots and adjust snapshot sizes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Introduces logic to exclude all build directory folders by default in new snapshots with an option to include them if needed. (node_modules, bower_components)
Benefits
Will result in smaller snapshot sizes and faster installs
Possible Drawbacks
Users will need to run 'npm install' on their local machines when they need to build files. This doesn't seem to be too big of an issue, as the packages are likely out of date and would need a pull from the repo and reinstall in any case.
Verification Process
wpsnapshots createcommand without any changes and noted the size of the snapshot zip file (178.8MB)wpsnapshots createcommand and noted the size of the snapshot zip file (131.6MB)wpsnapshots create --include_build_filesand verified the zip was created without the build folders.Checklist: