This repository was archived by the owner on May 2, 2022. It is now read-only.
Fix - Add node_modules to .eslintignore file#184
Open
fabiankaegy wants to merge 1 commit into10up:masterfrom
Open
Fix - Add node_modules to .eslintignore file#184fabiankaegy wants to merge 1 commit into10up:masterfrom
node_modules to .eslintignore file#184fabiankaegy wants to merge 1 commit into10up:masterfrom
Conversation
This is being added to the `node_modules` don't get scanned by `eslint`. This caused an issue when using `npm link` locally to test components.
timwright12
suggested changes
May 28, 2020
Contributor
timwright12
left a comment
timwright12
left a comment
There was a problem hiding this comment.
Can you add this into the plugin scaffold as well? Then we can merge.
https://github.com/10up/plugin-scaffold/
Member
|
@fabiankaegy are you able to mimic this PR in the plugin scaffold as well? |
Member
Author
|
@jeffpaul Thanks for the reminder. This got lost in my notifications. Will do |
Member
Author
|
@jeffpaul I have created a PR in the Plugin Template 10up/plugin-scaffold#123 |
Contributor
|
Noting that I want to test this with baseline components before merging since we are digging into node_modules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This is being added to the
node_modulesdon't get scanned byeslint. This caused an issue when usingnpm linklocally to test components.Checklist: