Update eslint globals

[cjkoepke]

Description of the Change

• Remove inline global variable declarations in webpack config files.
• Add global variable declarations to the .eslintrc file.
• Addresses Inline global declarations in the config files generate eslint errors. #180

Benefits

Avoids linting errors on initial commit from husky.

Verification Process

• Make a simple change and do a test commit (or run husky manually). It should not flag errors in the webpack config files.

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Applicable Issues

• Linting errors on webpack config files on initial commit and/or husky operation.

Changelog Entry

• Fix ESLINT errors on husky operation for webpack config files.

[nicholasio]

Do you mind changing .eslintc to .eslintrc.js since the former has been deprecated?

[cjkoepke]

@nicholasio From their docs

use a JavaScript, JSON or YAML file to specify configuration information for an entire directory and all of its subdirectories

I updated it to use .eslintrc.json does that work?

[nicholasio]

@cjkoepke yes, that's fine.

[timwright12]

@cjkoepke can you submit a PR to dover this issue in the plugin repo as well? I filed the issue you for here: 10up/plugin-scaffold#114 - we need to keep those repos sync'd up.

[timwright12]

Update plugin repo as well

[jeffpaul]

@cjkoepke are you able to mimic this PR over in the plugin repo?

[cjkoepke]

@jeffpaul Yeah, I'll get to this as soon as I can.

[cjkoepke]

@jeffpaul @timwright12 I've replicated this update on the plugin scaffold: 10up/plugin-scaffold#125

[timwright12]

@cjkoepke looks like we have some conflicts