You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 2, 2022. It is now read-only.
Unless we enable responsive-embeds support, we should add our own styles for styling embeds responsively. I've added a new blocks.css file for this. My thought is that if we add more block-specific styles, we can then start splitting this out into more specific partials (perhaps embeds.css in this case).
add_theme_support( 'disable-custom-font-sizes' );
— Disables the custom font size input box.
add_theme_support( 'disable-custom-colors' );
— disables the core colour palette
add_theme_support( 'editor-color-palette', array() );
— if we disable the core colour palette, we need to pass in our own array of (0) colours.
As Damon and I discussed in Slack, further work needs to be broken out into separate issues so we can properly have discussion around them. this is meant to be a few obvious defaults.
I would recommend we normalize the user-agent figure element's margin's with this responsive addition. Basically, when I check out your changes in theme scaffold the oembed has side margins. So, I would add to the top of the blocks.css:
I'm attaching a Before and After screenshot to bottom.
Adding in add_theme_support( 'disable-custom-font-sizes' );, add_theme_support( 'disable-custom-colors' );, and add_theme_support( 'editor-color-palette', array() ); disables these options from the Gutenberg editor, but already saved content is not affected. We would have to remove the enqueueing of Gutenberg's front-end styles to completely annihilate (should this be the desired approach) the affects of these settings.
This was not something I had considered before. 🤔
So, should we take on a redesign with lots of legacy Gutenberg content. And, we install the Theme
Scaffold with these new filters then the styled content will still exist. I guess this is not so bad, but
the user expectation might lead to a little confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale:
Unless we enable responsive-embeds support, we should add our own styles for styling embeds responsively. I've added a new blocks.css file for this. My thought is that if we add more block-specific styles, we can then start splitting this out into more specific partials (perhaps embeds.css in this case).
add_theme_support( 'disable-custom-font-sizes' );— Disables the custom font size input box.
add_theme_support( 'disable-custom-colors' );— disables the core colour palette
add_theme_support( 'editor-color-palette', array() );— if we disable the core colour palette, we need to pass in our own array of (0) colours.
As Damon and I discussed in Slack, further work needs to be broken out into separate issues so we can properly have discussion around them. this is meant to be a few obvious defaults.