Skip to content
This repository was archived by the owner on May 2, 2022. It is now read-only.

do not remove the viewbox from svgs#131

Open
gthayer wants to merge 1 commit into10up:masterfrom
gthayer:fix/svg-viewbox
Open

do not remove the viewbox from svgs#131
gthayer wants to merge 1 commit into10up:masterfrom
gthayer:fix/svg-viewbox

Conversation

@gthayer
Copy link

@gthayer gthayer commented Nov 24, 2020

Description of the Change

Opened an issue here: #130

Benefits

SVGs will display correctly on deployment

Possible Drawbacks

Perhaps there is a reason viewbox is removed which I am unaware of.

Verification Process

  1. If you site has SVGs, run npm run build to see the cropping
  2. npm run watch does not include the cropping because ImageminPlugin is disabled on non-production environments,.

Checklist:

  • [x ] I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Allowed for the display of SVG viewbox attributes when built in a production environment.

@joesnellpdx
Copy link
Collaborator

@gthayer

This looks fine to me. FYI - we will be moving to a singular scaffold soon - WIP: https://github.com/10up/wp-scaffold

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants