Skip to content
This repository was archived by the owner on May 2, 2024. It is now read-only.

Comments

Add Cache-Control header#13

Open
benoitchantre wants to merge 1 commit into10up:masterfrom
benoitchantre:cache-control
Open

Add Cache-Control header#13
benoitchantre wants to merge 1 commit into10up:masterfrom
benoitchantre:cache-control

Conversation

@benoitchantre
Copy link

Prevent changes by proxies.

Closes #12.

Copy link
Contributor

@TheLastCicada TheLastCicada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting thought to add no-transform here. Not sure if no-transform is the default I always want however. What benefit do you have in mind with this? What case would you make that we should prevent proxies from applying additional compression or other transformations to these files? I'm thinking of things like Cloudflare which can implement additional image compression or compress js or css files with brotli on the way through their proxy and I wouldn't necessarily want to prevent that.

@jeffpaul
Copy link
Member

@benoitchantre any responses to the questions in the prior comment from @TheLastCicada?

@benoitchantre
Copy link
Author

@TheLastCicada @jeffpaul Sorry for the late reply. I think my mind was focused on security. It skipped optimizations that can be provided by a CDN. For this reason, this header should be only added in specific cases (not by default).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Cache-Control header

3 participants