a standalone example that doesn't require Node.js#8
Open
tylerxue wants to merge 4 commits into0xProject:mainfrom
Open
a standalone example that doesn't require Node.js#8tylerxue wants to merge 4 commits into0xProject:mainfrom
tylerxue wants to merge 4 commits into0xProject:mainfrom
Conversation
a standalone example that doesn't require Node.js, RequireJs and Browserify and other unnecessary external dependencies.
Contributor
|
Thanks for the PR @tylerxue. Is this PR proposing changes that update the existing code to be an example that doesn't require Node.js, RequireJs, and Browserify or are you just suggesting that we create such an example? If it is the second, have you checked out our Next.js Demo App. We have more examples in the 0x-examples repo. If it is the first, can you please provide details on what code changes were made in this PR? |
Author
|
it's the first case, all changes are in the new folder named 'swap-demo-tutorial-part-tyler' which i think should be renamed if you plan to merge it.
so now for the app to start up and running, you dont need to install Node.js and build node_modules anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a standalone example that doesn't require Node.js, RequireJs and Browserify and other unnecessary external dependencies.