PEP it, pep it good #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's now a CLI-able code: `SPFlatten.py yourdomain.com` also fixed the missing allMechanism also fixed the redirect / recursion issue (i.e. facebook.com) lookup output is now debug output
|
LGTM. By the way, argparse would be good too. |
drzraf
pushed a commit
to drzraf/SPFlatten
that referenced
this pull request
Mar 22, 2021
- use argparse & logging - ability to handle an inlined SPF record (root domain name is optional) - Get rid of all the globals that made variable/state tracking impossible and handle recursion in a clean way - Rewritten on top of 0x9090#3
Contributor
Author
drzraf
pushed a commit
to drzraf/SPFlatten
that referenced
this pull request
Mar 26, 2021
- use argparse & logging - ability to handle an inlined SPF record (root domain name is optional) - Get rid of all the globals that made variable/state tracking impossible and handle recursion in a clean way - Rewritten on top of 0x9090#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now a CLI-able code:
SPFlatten.py yourdomain.comalso fixed the missing allMechanism
also fixed the redirect / recursion issue (i.e. facebook.com)
lookup output is now debug output