Draft
Conversation
…ck.Inner private, properly cancel threads on shutdown(?)
RedFlames
commented
Dec 15, 2024
| try { | ||
| foreach (CelesteNetConnection con in SafeDisposeQueue.GetConsumingEnumerable(ShutdownTokenSrc.Token)) { | ||
| if (con.IsAlive) { | ||
| Logger.Log("main", $"Safe dispose triggered for connection {con}"); |
Collaborator
Author
There was a problem hiding this comment.
I made this PR the last time we had a catastrophic lock disposal situation, I guess. Some kinda really rare race... this may be good to merge and see what it does on the server 🤔
Anyways TODO this line needs changing because it shouldn't default to VVV log level (honestly nothing ever should? Why is that the implicit level?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote this based off the exceptions that happen when you call /api/shutdown
Somehow this error still gets logged, despite everything shutting down correctly...
I have no idea if this breaks anything in how the server actually runs; I only went by testing /api/shutdown 🙂