Skip to content

Conversation

@abdotop
Copy link
Member

@abdotop abdotop commented Jan 9, 2026

Replaces self-referential @01edu/api imports with relative imports in api/dev.ts and api/doc.ts to fix module graph build error during publish.

Copilot AI review requested due to automatic review settings January 9, 2026 12:52
@abdotop abdotop force-pushed the fix-api-pkg-imports branch from 711f02a to 105441a Compare January 9, 2026 12:54
@abdotop abdotop merged commit 9234eb3 into master Jan 9, 2026
1 check passed
@abdotop abdotop deleted the fix-api-pkg-imports branch January 9, 2026 12:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a module graph build error by replacing self-referential @01edu/api imports with relative imports in internal api/dev.ts and api/doc.ts files. Additionally, the Sql type definition is extracted from db/mod.ts and moved to a new types/db.d.ts file to establish a proper dependency hierarchy.

  • Fixed circular dependency issues by using relative imports for internal modules
  • Extracted Sql type to @01edu/types/db to avoid module graph conflicts
  • Updated all references to import Sql from the new location

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Show a summary per file
File Description
types/deno.json Version bump to 0.1.4, added @db/sqlite dependency, and new export for ./db
types/db.d.ts New type definition file exporting the Sql type
deno.lock Lock file update to track @db/sqlite dependency for types package
db/mod.ts Removed Sql type definition and imported it from @01edu/types/db
api/router.ts Updated Sql import to use @01edu/types/db
api/doc.ts Replaced self-referential @01edu/api/* imports with relative imports
api/dev.ts Replaced self-referential @01edu/api/* imports with relative imports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants