Skip to content

Conversation

@abdotop
Copy link
Member

@abdotop abdotop commented Jan 15, 2026

refactor: Refactor columnsMap to a plain object and adjust its usage, alongside various UI layout and overflow fixes.

@abdotop abdotop self-assigned this Jan 15, 2026
Copilot AI review requested due to automatic review settings January 15, 2026 14:23
@abdotop abdotop linked an issue Jan 15, 2026 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the columnsMap data structure from a Map<string, ColumnInfo> to a plain JavaScript object (Record<string, ColumnInfo>), and includes several UI layout fixes to address overflow issues.

Changes:

  • Refactored columnsMap from Map to plain object in schema refresh logic
  • Added overflow and sizing fixes to UI components for better layout control
  • Reconstructed Map from plain object when needed for table data fetching

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
api/sql.ts Changed columnsMap construction to use plain object instead of Map
api/routes.ts Added logic to reconstruct Map from plain object when calling fetchTablesData
web/pages/DeploymentPage.tsx Changed table width class from w-full to min-w-full
web/components/SideBar.tsx Added overflow-hidden class to drawer-side container
web/components/BackgroundPattern.tsx Added explicit sizing constraints to fixed background container
Comments suppressed due to low confidence (2)

api/sql.ts:92

  • The TableInfo type definition still declares columnsMap as Map<string, ColumnInfo>, but the implementation now stores it as Record<string, ColumnInfo>. Update the type definition to match: columnsMap: Record<string, ColumnInfo>
  columnsMap: Map<string, ColumnInfo>

api/sql.ts:110

  • The initialization still uses new Map() but should be changed to {} to match the new plain object implementation.
        tableMap.set(key, { schema, table, columns: [], columnsMap: new Map() })

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…e, alongside various UI layout and overflow fixes.
@abdotop abdotop force-pushed the 88-bug-auto-refresh-does-not-trigger-in-query-views branch from 4df3432 to 122cabc Compare January 15, 2026 14:44
@abdotop abdotop merged commit 03e6c27 into master Jan 15, 2026
2 checks passed
@abdotop abdotop deleted the 88-bug-auto-refresh-does-not-trigger-in-query-views branch January 15, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Auto-refresh does not trigger in query views

2 participants