Trying to provide a pull request but fails to build

[netskink]

Hello folks,

I'm am trying to provide a pull request, but I can't get a build to work. I don't see instructions on how to build this code, but with that said this is my process.

clone code

$ git clone git@github.com:ZOSOpenTools/zoslibport.git

Check to see if tags are EBCIDIC or ASCII

$ cd zoslibport
$ find . -type f | xargs chtag -p

The result is all ascii, that is good. In the other issue, I had problems with them being EBCIDIC. Perhaps this was resolved.

Attempt to build the code

$ zopen build -v
Checking environment configuration
VERBOSE: 'Implicitly adding git dependencies: git'
***ERROR: xlclang compiler specified, need to be running IBM C for Open Enterprise Languages on z/OS 1

I'll put this on hold and work on the easy readme problems.

[IgorTodorovskiIBM]

Check if you're on the latest meta, but even with that it'll probably fail here:
https://github.com/ZOSOpenTools/comp_xlclangport/blob/main/buildenv#L65
You probably have an older version of xlclang. You can try to bypass it if updating to the latest xlclang is not an option.

[netskink]

If you mean latest meta, I do this periodically.

$ zopen upgrade

To be sure that I am on latest, I did that just now.

I have two sets of compilers available. For this particular build should I use the stock xlclang or the open one?

$ ibm-clang --version
IBM Open XL C/C++ 1.1 for z/OS, (5650-ZOS), clang version 14.0.0
Target: s390x-ibm-zos
Thread model: posix
InstalledDir: /usr/lpp/IBM/cnw/v1r1/openxl/bin

or

$  xlclang --version
<opens a man page like thing with z/OS V2.4.1 XL C/C++ at top>

Lastly how to specify to zopen build to use the approriate compiler?

[IgorTodorovskiIBM]

Only xlclang works to build zoslib for now.
If you're on the latest meta branch it should implicitly add comp_xlclang as a dependency and perform the checks here: https://github.com/ZOSOpenTools/comp_xlclangport/blob/main/buildenv#L65.
Make sure to pull in the latest changes from meta as it seems you're not on the latest. It's likely that the COMPILER_VER is a bit older (<42040001) for your version of xlclang.

[netskink]

The $ zopen upgrade shows this for meta

<stuff snipped>
Installing ncurses...
installDependencies 33: installPort 44: installPorts 8: /z/jd895801/zopen/boot/meta-main/bin/lib/zopen-install 452: FSUM7343 cannot open "man-db/.depsenv" for output: EDC5129I No such file or directory.
Installing meta...
Installing nano...
<stuff snipped>

Am I safe to assume I am on the latest meta?

[netskink]

Do you have a url for where to find the install for the proper version of xlclang? I can't just install it but I do need a concise method to give to the admins.

[IgorTodorovskiIBM]

I believe the latest one is here: https://www-40.ibm.com/servers/resourcelink/svc00100.nsf/pages/xlCC++V241ForZOsV24?OpenDocument . Unfortunately, there seems to be 2 versions of v2.4.1 and the __COMPILER_VER__ macro is the best way to verify.

[netskink]

This is what I have

$  xlclang -E -qshowmacros foo.cc | grep __COMPILER
#define __COMPILER_VER__ 0x42030001

Please, can you provide the shopz reference for the necessary compiler? A mainframe system programmer is assisting helping me, but they need a FMID or Product Code for Shop Z.

[netskink]

This is the product ID for the compiler we have installed: 5650ZOS

[IgorTodorovskiIBM]

I got this information from the product manager:

HLB77C0 is the base XL C/C++ 2.4 compiler; HLB77C1 is XL C/C++ 2.4.1. HLB77C2 is Open XL C/C++ 1.1 — both are optional web deliverable add-ons with modern C/C++ language support for clients that have enabled HLB77C0.

So it should be HLB77C1

[netskink]

Many thanks!

[netskink]

@IgorTodorovskiIBM , the system programmer attempted to down the url you provided here

I believe the latest one is here: https://www-40.ibm.com/servers/resourcelink/svc00100.nsf/pages/xlCC++V241ForZOsV24?OpenDocument . Unfortunately, there seems to be 2 versions of v2.4.1 and the COMPILER_VER macro is the best way to verify.

We definitely have /bin/xlc --version as 2.4 and not 2.4.1

Sadly the 2.4.1 version which corresponds to HLB77C1, can not be found. That link above is 2.4 aka HLB77C0.

Please advise.

John

[IgorTodorovskiIBM]

Hi John,

Sorry about that, before Shop Z, you will need to get the sys admin to install the GA SMP/E image from the web download page (as these are web deliverables) and then servicing/support is through shopZ. Basically a GA is a ++FMID SYSMOD, a PTF is a ++PTF SYSMOD — they are different types of SYSMODs. In order to install the ++PTF, they will need the ++FMID SYSMOD first. GA images are at:
HLB77C1: https://www-40.ibm.com/servers/resourcelink/svc00100.nsf/pages/xlCC++V241ForZOsV24?OpenDocument
HLB77C2: https://www-40.ibm.com/servers/resourcelink/svc00100.nsf/pages/openXlCC++11ForZOs24AndZOs25?OpenDocument

[netskink]

Igor,

Awesome! I'm impressed with your speedy reply. I have forwarded your info to the system programmer.

Many thanks

John

[netskink]

@IgorTodorovskiIBM our system programmer installed the specified HLB77C1 install. The HLB77C2 corresponding to the open compiler was previously installed.

Now, if I look at $ xlc* --version, xlc and xlc++ is still 2.4. xlclang and xlclang++ are now 2.4.1.

However, the error message when trying to compile from source remains the same.

$ ./build.sh -c -r -s -t
~/zopen/dev/try2/zoslib/build ~/zopen/dev/try2/zoslib
-- The CXX compiler identification is zOS 420.3.1
-- The C compiler identification is zOS 420.3.1
-- The ASM compiler identification is GNU
-- Found assembler: /bin/xlclang
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - failed
-- Check for working CXX compiler: /bin/xlclang++
-- Check for working CXX compiler: /bin/xlclang++ - broken

CMake Error at /z/xxxx/zopen/prod/CMake-heads.v3.24.2/share/cmake-3.24/Modules/CMakeTestCXXCompiler.cmake:62 (message):
  The C++ compiler

    "/bin/xlclang++"

  is not able to compile a simple test program.

Also, regarding the error the CMakeTestCXXCompiler.cmake file generates the error at line 62. Prior to that it tries to compile testCXXCompiler.cxx. Where is this file? I don't see it.

$ cd zopen/prod/
$ ls -ld cmake*
lrwxrwxrwx   1 xxxxxx xxxxx      19 May  9 11:39 cmake -> CMake-heads.v3.24.2
$ find . -name testCXXCompiler.cxx
$

Please advise.

[IgorTodorovskiIBM]

@perry-ca , you might have a better idea on what's going on here?

@netskink , does /bin/xlclang++ create an executable? Can you confirm with a simple "hello world" test?