From 6d59f36e726310c184b1466d9346efda29da4767 Mon Sep 17 00:00:00 2001 From: "mr .bo" Date: Fri, 9 Sep 2016 16:17:49 -0400 Subject: [PATCH] add comments matter --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 2efb72e..bfb2000 100755 --- a/README.md +++ b/README.md @@ -57,6 +57,7 @@ Below is the detailed documentation for review principles, etiquette, and flow. - Every commit should be accompanied by a message that describes the code change well. - For major features, merge production code to the feature branch often to ensure backwards compatibility. - Every PR should have a main assignee, who would sign off on the PR and notify the author to merge the code in. + - All "non-LGTM" comments are considered show-stoppers and must be addressed before merging. - All code should be well-tested and well-documented during the review process. ## Branching Strategy